From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 44F241DEFDC for ; Sun, 9 Feb 2025 17:54:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739123649; cv=none; b=Yq9jV6Dm2qWYpBzqsNwoBa6iT2YjedGNREa1q+7tYUnxgs5hKshKZyMvMBh0IPGbzTFSUdufQz7hoREZD4wPUcVq6MUtwc3DLvByFZyxMaACBzjomv+Tuff9vjExZvRDcePeTz3xUhSB6D/qD830n9B1YNM2GWCKolnVgM88h4g= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739123649; c=relaxed/simple; bh=k99UAQAdKzxoqi1fK05SSQ9xO4q/5wpfZNfxu+vdzsc=; h=From:In-Reply-To:References:To:Cc:Subject:MIME-Version: Content-Type:Date:Message-ID; b=CUBVass95XTIIDfwTZZkZsrU5reHMkNVTLu4RnwyOM8/HGIPkYETf7kkPu8j7Y7rajBa4xleRirDeHAv8tCjB+UYl547tl84dvVpWvRLMzPOhLonu1tVtBWqz6svNohVD6Fqy8rQTDTpi+EvygyPwp2qBM01O1Tzl+wFB6gA10c= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=T4GoMVA9; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="T4GoMVA9" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1739123647; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HZy+2KXL+332PNbEE4REP74hQEw249CGirMqJVtIdAE=; b=T4GoMVA9zY5r2urREcgSZxGf2hoBUYYV5Nsiv12vZcYRFglOhj/9LTrSdrLt9lpixnkyy5 ZlePnzTzMYDFGr8NhBtMKiZqMguJoPq4orCbXQlp2DBVQYn8lemnGM+o5jJTsomZKM77zX km5v9iCjNN3hS2iw1DyV/d0ks1XCi7w= Received: from mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (ec2-35-165-154-97.us-west-2.compute.amazonaws.com [35.165.154.97]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-179-fiKubr2EN-OLiH49vN8dyQ-1; Sun, 09 Feb 2025 12:54:03 -0500 X-MC-Unique: fiKubr2EN-OLiH49vN8dyQ-1 X-Mimecast-MFC-AGG-ID: fiKubr2EN-OLiH49vN8dyQ Received: from mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com [10.30.177.93]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mx-prod-mc-08.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTPS id 72BCF180036F; Sun, 9 Feb 2025 17:54:00 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.42.28.92]) by mx-prod-int-06.mail-002.prod.us-west-2.aws.redhat.com (Postfix) with ESMTP id 794E51800360; Sun, 9 Feb 2025 17:53:55 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: References: <20250203142343.248839-1-dhowells@redhat.com> <20250203142343.248839-4-dhowells@redhat.com> To: Herbert Xu Cc: dhowells@redhat.com, netdev@vger.kernel.org, Marc Dionne , Jakub Kicinski , "David S. Miller" , Eric Dumazet , Paolo Abeni , Simon Horman , Trond Myklebust , Chuck Lever , Eric Biggers , Ard Biesheuvel , linux-crypto@vger.kernel.org, linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net 03/24] crypto: Add 'krb5enc' hash and cipher AEAD algorithm Precedence: bulk X-Mailing-List: linux-nfs@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1934017.1739123634.1@warthog.procyon.org.uk> Content-Transfer-Encoding: quoted-printable Date: Sun, 09 Feb 2025 17:53:54 +0000 Message-ID: <1934018.1739123634@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.4.1 on 10.30.177.93 Herbert Xu wrote: > > [!] Note that the net/sunrpc/auth_gss/ implementation gets a pair of > > ciphers, one non-CTS and one CTS, using the former to do all the align= ed > > blocks and the latter to do the last two blocks if they aren't also > > aligned. It may be necessary to do this here too for performance reas= ons - > > but there are considerations both ways: > = > The CTS template will take any hardware accelerated CBC implementation > and turn it into CTS. > = > So there is no reason to do the CTS/CBC thing by hand at all. Glad to hear it. I'm just reporting what net/sunrpc/ does now. My suspic= ion is that this is from before a lot of cpu crypto-based optimisations were m= ade available in the crypto layer. David