Linux NFS development
 help / color / mirror / Atom feed
From: Weston Andros Adamson <dros@primarydata.com>
To: "Toralf Förster" <toralf.foerster@gmx.de>
Cc: Trond Myklebust <trond.myklebust@primarydata.com>,
	Weston Andros Adamson <weston.adamson@primarydata.com>,
	linux-nfs list <linux-nfs@vger.kernel.org>
Subject: Re: fuzz testing a 32 bit UML guest with NFSv4 gave: BUG kmalloc-256 (Not tainted): Redzone overwritten
Date: Thu, 14 Aug 2014 12:57:14 -0400	[thread overview]
Message-ID: <1E9DB9D4-A4DF-4D58-918F-DAFE0004E2C0@primarydata.com> (raw)
In-Reply-To: <53ECE285.4080200@gmx.de>

Sorry, that was from a backport.

The correct commit is:

commit 6094f83864c1d1296566a282cba05ba613f151ee
Author: Weston Andros Adamson <dros@primarydata.com>
Date:   Thu May 15 11:56:50 2014 -0400

    nfs: allow coalescing of subpage requests

My fix seems to work, but I still need to clean it up a bit.

-dros



On Aug 14, 2014, at 12:23 PM, Toralf Förster <toralf.foerster@gmx.de> wrote:

> On 08/14/2014 12:00 AM, Weston Andros Adamson wrote:
>> There are two solutions:
>> 
>> 1) introduce a new check in nfs_can_coalesce_requests - basically the same
>>    tests as were removed in commit 362251a0eb540cf2537d78d508b2bcd87fe66321, but each with:
>>   && req->wb_page != prev->wb_page.
> 
> Hhm,
> 
> tfoerste@n22 ~/devel/linux $ git show 362251a0eb540cf2537d78d508b2bcd87fe66321
> fatal: bad object 362251a0eb540cf2537d78d508b2bcd87fe66321
> 
> 
> -- 
> Toralf
> 


      reply	other threads:[~2014-08-14 16:57 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-07-27  9:47 fuzz testing a 32 bit UML guest with NFSv4 gave: BUG kmalloc-256 (Not tainted): Redzone overwritten Toralf Förster
2014-07-27 16:06 ` Trond Myklebust
2014-07-29 15:33   ` Weston Andros Adamson
2014-08-13 22:00     ` Weston Andros Adamson
2014-08-14 16:23       ` Toralf Förster
2014-08-14 16:57         ` Weston Andros Adamson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1E9DB9D4-A4DF-4D58-918F-DAFE0004E2C0@primarydata.com \
    --to=dros@primarydata.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=toralf.foerster@gmx.de \
    --cc=trond.myklebust@primarydata.com \
    --cc=weston.adamson@primarydata.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox