Re: [PATCH 1/1] PNFS fix fallback to MDS if got error on commit to DS

[Anna Schumaker <schumaker.anna@gmail.com>]

Hi Olga,

On 03/30/2017 10:10 AM, Olga Kornievskaia wrote:
> Upong receiving some errors (EACCES) on commit to the DS the code
> doesn't fallback to MDS and intead retrieds to the same DS again.

Just so I know what's going on: do you want this patch instead of the first one in the thread?

Thanks,
Anna
> 
> Signed-off-by: Olga Kornievskaia <kolga@netapp.com>
> ---
>  fs/nfs/filelayout/filelayout.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/fs/nfs/filelayout/filelayout.c b/fs/nfs/filelayout/filelayout.c
> index a3fc48b..59e1efa 100644
> --- a/fs/nfs/filelayout/filelayout.c
> +++ b/fs/nfs/filelayout/filelayout.c
> @@ -202,10 +202,10 @@ static int filelayout_async_handle_error(struct rpc_task *task,
>  			task->tk_status);
>  		nfs4_mark_deviceid_unavailable(devid);
>  		pnfs_error_mark_layout_for_return(inode, lseg);
> -		pnfs_set_lo_fail(lseg);
>  		rpc_wake_up(&tbl->slot_tbl_waitq);
>  		/* fall through */
>  	default:
> +		pnfs_set_lo_fail(lseg);
>  reset:
>  		dprintk("%s Retry through MDS. Error %d\n", __func__,
>  			task->tk_status);
>