From: Jeff Layton <jlayton@kernel.org>
To: NeilBrown <neilb@suse.de>, Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org, Olga Kornievskaia <kolga@netapp.com>,
Dai Ngo <Dai.Ngo@oracle.com>, Tom Talpey <tom@talpey.com>
Subject: Re: [PATCH 0/6 v2] support admin-revocation of v4 state
Date: Thu, 02 Nov 2023 07:29:29 -0400 [thread overview]
Message-ID: <1c79ea86a5e813ac24f57f04dab48766570c3f35.camel@kernel.org> (raw)
In-Reply-To: <20231101010049.27315-1-neilb@suse.de>
On Wed, 2023-11-01 at 11:57 +1100, NeilBrown wrote:
> This set fixes two issues found by kernel test robot
> 1/ nfsd4_revoke_states() needs to be defined when not CONFIG_NFSD_V4
> 2/ nfs40_last_revoke is larger than a mechine word in 32 bit configs,
> so needs protection - use nn->client_lock which is already taken when
> nfs40_last_revoke is accessed.
>
> NeilBrown
>
In general, the series looks like something reasonable to do (and
something admins would welcome). I have some (long standing) concerns
around the sc_type value though that I think we probably need to address
prior to or in conjunction with this set.
Cheers,
--
Jeff Layton <jlayton@kernel.org>
prev parent reply other threads:[~2023-11-02 11:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-01 0:57 [PATCH 0/6 v2] support admin-revocation of v4 state NeilBrown
2023-11-01 0:57 ` [PATCH 1/6] nfsd: prepare for supporting admin-revocation of state NeilBrown
2023-11-01 2:14 ` Chuck Lever III
2023-11-01 2:49 ` NeilBrown
2023-11-02 10:46 ` Jeff Layton
2023-11-02 20:03 ` NeilBrown
2023-11-02 20:24 ` Jeff Layton
2023-11-02 20:29 ` Chuck Lever III
2023-11-03 1:08 ` NeilBrown
2023-11-03 14:34 ` Chuck Lever
2023-11-03 17:25 ` Jeff Layton
2023-11-02 11:25 ` Jeff Layton
2023-11-01 0:57 ` [PATCH 2/6] nfsd: allow admin-revoked state to appear in /proc/fs/nfsd/clients/*/states NeilBrown
2023-11-01 0:57 ` [PATCH 3/6] nfsd: allow admin-revoked NFSv4.0 state to be freed NeilBrown
2023-11-01 0:57 ` [PATCH 4/6] nfsd: allow lock state ids to be revoked and then freed NeilBrown
2023-11-01 0:57 ` [PATCH 5/6] nfsd: allow open " NeilBrown
2023-11-01 0:57 ` [PATCH 6/6] nfsd: allow delegation " NeilBrown
2023-11-01 2:10 ` Chuck Lever III
2023-11-01 3:01 ` NeilBrown
2023-11-01 5:41 ` Chuck Lever III
2023-11-01 7:43 ` NeilBrown
2023-11-01 15:41 ` Chuck Lever III
2023-11-01 17:41 ` dai.ngo
2023-11-02 11:29 ` Jeff Layton [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1c79ea86a5e813ac24f57f04dab48766570c3f35.camel@kernel.org \
--to=jlayton@kernel.org \
--cc=Dai.Ngo@oracle.com \
--cc=chuck.lever@oracle.com \
--cc=kolga@netapp.com \
--cc=linux-nfs@vger.kernel.org \
--cc=neilb@suse.de \
--cc=tom@talpey.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox