Re: [PATCH v1 01/19] svcrdma: Add proper SPDX tags for NetApp-contributed source

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 4732 bytes --]

On Wed, 2018-05-09 at 16:42 -0400, Chuck Lever wrote:
> > On May 9, 2018, at 4:23 PM, J. Bruce Fields <bfields@fieldses.org> wrote:
> > 
> > Looking at the git history, it looks like others are taking this as an
> > opportunity to replace the existing boilerplate.  Could we do this here?
> > Looks like "BSD-3-Clause" does in fact refer to a license that's
> > word-for-word the same as the one included here (except for the name of
> > the copyright holder), so I wonder if we need it written out here any
> > more.
> > 
> > (Minor point, I'm applying this anyway and you can follow up with the
> > remval patch or not.)
> 
> Because the holder's name is part of the boilerplate, I feel
> that it is up to the holder to submit a patch removing the
> whole copyright notice if they are comfortable doing that.
> 
> But IANAL. Feel free to convince me that I'm being prudish.

As long as you leave their ownership statement, the SPDX replacement is
a direct replacement for the license text.  Just because the two are in
the same comment block (the ownership statement and date, and the text
of the actual license) does not mean they are a single item.  The
license is a license, the other is an ownership statement, and replacing
the long form license term with an accepted short form license term that
is regarded as being identical to the long form is perfectly acceptable.

> 
> > --b.
> > 
> > On Mon, May 07, 2018 at 03:26:55PM -0400, Chuck Lever wrote:
> > > Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> > > ---
> > > include/linux/sunrpc/svc_rdma.h          |    1 +
> > > net/sunrpc/xprtrdma/svc_rdma.c           |    1 +
> > > net/sunrpc/xprtrdma/svc_rdma_recvfrom.c  |    1 +
> > > net/sunrpc/xprtrdma/svc_rdma_sendto.c    |    1 +
> > > net/sunrpc/xprtrdma/svc_rdma_transport.c |    1 +
> > > 5 files changed, 5 insertions(+)
> > > 
> > > diff --git a/include/linux/sunrpc/svc_rdma.h b/include/linux/sunrpc/svc_rdma.h
> > > index 7337e12..88da0c9 100644
> > > --- a/include/linux/sunrpc/svc_rdma.h
> > > +++ b/include/linux/sunrpc/svc_rdma.h
> > > @@ -1,3 +1,4 @@
> > > +/* SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause */
> > > /*
> > >  * Copyright (c) 2005-2006 Network Appliance, Inc. All rights reserved.
> > >  *
> > > diff --git a/net/sunrpc/xprtrdma/svc_rdma.c b/net/sunrpc/xprtrdma/svc_rdma.c
> > > index dd8a431..a490532 100644
> > > --- a/net/sunrpc/xprtrdma/svc_rdma.c
> > > +++ b/net/sunrpc/xprtrdma/svc_rdma.c
> > > @@ -1,3 +1,4 @@
> > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> > > /*
> > >  * Copyright (c) 2005-2006 Network Appliance, Inc. All rights reserved.
> > >  *
> > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> > > index 3d45015..9eae95d 100644
> > > --- a/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> > > +++ b/net/sunrpc/xprtrdma/svc_rdma_recvfrom.c
> > > @@ -1,3 +1,4 @@
> > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> > > /*
> > >  * Copyright (c) 2016, 2017 Oracle. All rights reserved.
> > >  * Copyright (c) 2014 Open Grid Computing, Inc. All rights reserved.
> > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_sendto.c b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> > > index 649441d..79bd3a3 100644
> > > --- a/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> > > +++ b/net/sunrpc/xprtrdma/svc_rdma_sendto.c
> > > @@ -1,3 +1,4 @@
> > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> > > /*
> > >  * Copyright (c) 2016 Oracle. All rights reserved.
> > >  * Copyright (c) 2014 Open Grid Computing, Inc. All rights reserved.
> > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > > index 96cc8f6..3633254 100644
> > > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > > @@ -1,3 +1,4 @@
> > > +// SPDX-License-Identifier: GPL-2.0 OR BSD-3-Clause
> > > /*
> > >  * Copyright (c) 2014 Open Grid Computing, Inc. All rights reserved.
> > >  * Copyright (c) 2005-2007 Network Appliance, Inc. All rights reserved.
> > 
> > --
> > To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> > the body of a message to majordomo@vger.kernel.org
> > More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 
> --
> Chuck Lever
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]