From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id EEE87C38145 for ; Wed, 7 Sep 2022 10:08:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229436AbiIGKIe (ORCPT ); Wed, 7 Sep 2022 06:08:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52624 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229765AbiIGKI3 (ORCPT ); Wed, 7 Sep 2022 06:08:29 -0400 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E90B1B07E8; Wed, 7 Sep 2022 03:08:28 -0700 (PDT) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 879F76185F; Wed, 7 Sep 2022 10:08:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DA523C433C1; Wed, 7 Sep 2022 10:08:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1662545307; bh=dP9xemqn6VbnteZEmIn3ds2pIeYUmDTcWHEmiXzGBTk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=Xi+zWNl38ktfZCKaIUaOuBtI3xHQV5b6MmHRUDjUig8Om3/TXY0VNI+pk5plfcCq4 NXZEdvYpzKspgBrw59t4Tl638/GAQIYcmaor0Kgnh3pATHhuIvrVpUrI2xye8tLXDM 81ixy8JsORoIQmmHMfwbSCJlmrY93lcbnDYBIak2LZkWwrqhEK4YtyFhgDX2yrKVlW Il3v/E33aIQ0X4cF1z8bXahMi5W0ivMy4SjNwzT12KkUEKKP+nJQm096Nnz0rV798X RaFD06sQUbOOyUteNygK59B2cVcvS1gKUMUmNxK5ztx18yxmvV5dJg1db/dPZcnPS1 1WDRNSTvQXi+Q== Message-ID: <1e0877bc528f3e9218f0070889c7288a8aaa47ba.camel@kernel.org> Subject: Re: [PATCH] SUNRPC: Fix potential memory leak in xs_udp_send_request() From: Jeff Layton To: Jianglei Nie , chuck.lever@oracle.com, trond.myklebust@hammerspace.com, anna@kernel.org, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com Cc: linux-nfs@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Date: Wed, 07 Sep 2022 06:08:25 -0400 In-Reply-To: <20220907071338.56969-1-niejianglei2021@163.com> References: <20220907071338.56969-1-niejianglei2021@163.com> Content-Type: text/plain; charset="ISO-8859-15" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.44.4 (3.44.4-1.fc36) MIME-Version: 1.0 Precedence: bulk List-ID: X-Mailing-List: linux-nfs@vger.kernel.org On Wed, 2022-09-07 at 15:13 +0800, Jianglei Nie wrote: > xs_udp_send_request() allocates a memory chunk for xdr->bvec with > xdr_alloc_bvec(). When xprt_sock_sendmsg() finishs, xdr->bvec is not > released, which will lead to a memory leak. >=20 > we should release the xdr->bvec with xdr_free_bvec() after > xprt_sock_sendmsg() like bc_sendto() does. >=20 > Signed-off-by: Jianglei Nie > --- > net/sunrpc/xprtsock.c | 1 + > 1 file changed, 1 insertion(+) >=20 > diff --git a/net/sunrpc/xprtsock.c b/net/sunrpc/xprtsock.c > index e976007f4fd0..298182a3c168 100644 > --- a/net/sunrpc/xprtsock.c > +++ b/net/sunrpc/xprtsock.c > @@ -958,6 +958,7 @@ static int xs_udp_send_request(struct rpc_rqst *req) > return status; > req->rq_xtime =3D ktime_get(); > status =3D xprt_sock_sendmsg(transport->sock, &msg, xdr, 0, 0, &sent); > + xdr_free_bvec(xdr); > =20 > dprintk("RPC: xs_udp_send_request(%u) =3D %d\n", > xdr->len, status); I think you're probably correct here. I was thinking we might have a similar bug in svc_tcp_sendmsg, but it looks like that one gets freed in svc_tcp_sendto. Reviewed-by: Jeff Layton