From: Olaf Kirch <okir@suse.de>
To: Chuck Lever <cel@citi.umich.edu>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Linux NFS List <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] NFS client doesn't flush dirty mmap'd pages during fsync/msync
Date: Tue, 20 Jan 2004 13:01:17 +0100 [thread overview]
Message-ID: <20040120120116.GP17993@suse.de> (raw)
In-Reply-To: <Pine.BSO.4.33.0401141300540.10050-100000@citi.umich.edu>
Hi,
On Wed, Jan 14, 2004 at 01:46:27PM -0500, Chuck Lever wrote:
> the nfs_writepage interface causes dirty mmap'd pages to be queued on an
> NFS inode's dirty page queue. these pages are queued with a NULL filp
> because a filp is not available via the nfs_writepage interface. when
> nfs_fsync is invoked (either via fsync() or via msync()), it is looking
> specifically for dirty pages associated with a given filp, so it skips the
> dirty pages with a NULL filp.
Given that we have the inode for these dirty pages, couldn't we at least
compare the req->wb_inode to filp->f_dentry->d_inode? With your patch,
an fsync degenerates to a global sync on the mounted file system, if
I'm not mistaken.
Olaf
--
Olaf Kirch | Stop wasting entropy - start using predictable
okir@suse.de | tempfile names today!
---------------+
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2004-01-20 12:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-01-14 18:46 [PATCH] NFS client doesn't flush dirty mmap'd pages during fsync/msync Chuck Lever
2004-01-20 12:01 ` Olaf Kirch [this message]
2004-01-20 13:31 ` trond.myklebust
-- strict thread matches above, loose matches on Subject: below --
2004-01-20 13:55 Lever, Charles
2004-01-20 14:37 ` trond.myklebust
2004-01-20 14:58 ` Olaf Kirch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040120120116.GP17993@suse.de \
--to=okir@suse.de \
--cc=cel@citi.umich.edu \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox