From: Olaf Kirch <okir@suse.de>
To: Greg Banks <gnb@melbourne.sgi.com>
Cc: Trond Myklebust <trond.myklebust@fys.uio.no>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>
Subject: Re: [PATCH] SGI 882960: Busy inodes after unmount, oops
Date: Wed, 4 Feb 2004 11:42:25 +0100 [thread overview]
Message-ID: <20040204104225.GI20323@suse.de> (raw)
In-Reply-To: <40209B6D.56ED461E@melbourne.sgi.com>
Hi Greg,
On Wed, Feb 04, 2004 at 06:12:45PM +1100, Greg Banks wrote:
> This patch fixes a bug where the forced killing of pending asynchronous
> unlink rpc_tasks during unmount leaks inode reference counts for the
> parent of the silly-renamed file and all its ancestor directories,
> resulting in the message
>
> VFS: Busy inodes after unmount. Self-destruct in 5 seconds. Have a nice day...
Finally! This bug was driving me nuts. I wasn't even able to reproduce
this under lab conditions :-/
> The first part makes sure that dput() will unhash and kill dentries
> and their parents if called while the unmount is underway.
>
> The second part moves the dput() call from the tk_exit callback of
> the async unlink rpc_task to the tk_release callback so that it
> will be called if the rpc_task is killed by rpc_killall_tasks()
> instead of completing normally.
Yes, that looks as if this could fix the problem.
Thanks again,
Olaf
--
Olaf Kirch | Stop wasting entropy - start using predictable
okir@suse.de | tempfile names today!
---------------+
-------------------------------------------------------
The SF.Net email is sponsored by EclipseCon 2004
Premiere Conference on Open Tools Development and Integration
See the breadth of Eclipse activity. February 3-5 in Anaheim, CA.
http://www.eclipsecon.org/osdn
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2004-02-04 10:47 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-02-04 7:12 [PATCH] SGI 882960: Busy inodes after unmount, oops Greg Banks
2004-02-04 10:42 ` Olaf Kirch [this message]
2004-02-04 22:59 ` Greg Banks
2004-02-04 12:09 ` Olaf Kirch
2004-02-04 22:41 ` Greg Banks
2004-02-05 16:15 ` Olaf Kirch
2004-02-05 22:23 ` Greg Banks
2004-02-06 5:50 ` Greg Banks
2004-02-13 16:26 ` canon
2004-02-04 14:24 ` raven
2004-02-04 22:56 ` Greg Banks
2004-02-05 12:40 ` James Pearson
2004-02-09 7:46 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040204104225.GI20323@suse.de \
--to=okir@suse.de \
--cc=gnb@melbourne.sgi.com \
--cc=nfs@lists.sourceforge.net \
--cc=trond.myklebust@fys.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox