Re: nfsd: terminating on error 104 problem

[Olaf Kirch <okir@suse.de>]

[-- Attachment #1: Type: text/plain, Size: 654 bytes --]

On Thu, Mar 04, 2004 at 10:41:02AM +0000, Johan van den Dorpe wrote:
> So from my limited knowledge of the kernel source I can see that 
> "terminating on error 104" corresponds to line 221 of
> /usr/src/linux-2.4.25/fs/nfsd/nfssvc.c. So svc_recv on line 191 is 
> obviously returning -104.

104 is ECONNRESET, this means the client reset the connection.
The server should really clean up the socket in this case.

Does the attached patch help? 

Beware - totally untested, better not try this on a production
machine :)

Olaf
-- 
Olaf Kirch     |  Stop wasting entropy - start using predictable
okir@suse.de   |  tempfile names today!
---------------+ 

[-- Attachment #2: nfsd-handle-econnreset --]
[-- Type: text/plain, Size: 483 bytes --]

--- svcsock.c.orig	2004-03-04 12:08:51.000000000 +0100
+++ svcsock.c	2004-03-04 12:10:08.000000000 +0100
@@ -904,6 +904,10 @@
 	if (len == -EAGAIN) {
 		dprintk("RPC: TCP recvfrom got EAGAIN\n");
 		svc_sock_received(svsk);
+	} else if (len == -ECONNRESET) {
+		dprintk("RPC: TCP recvfrom got ECONNRESET\n");
+		svc_sock_received(svsk);
+		set_bit(SK_DEAD, &svsk->sk_flags);
 	} else {
 		printk(KERN_NOTICE "%s: recvfrom returned errno %d\n",
 					svsk->sk_server->sv_name, -len);