From: "Jose R. Santos" <jrsantos@austin.ibm.com>
To: nfs@lists.sourceforge.net
Subject: BKL removal from find_exported_dentry()
Date: Tue, 9 Mar 2004 07:54:51 -0600 [thread overview]
Message-ID: <20040309135451.GC30766@rx8.ibm.com> (raw)
Hi all
I was running SpecSFS on a 8-way machine when I encounter a situation were
find_exported_dentry() was showing up to 75% in my profiles. After some
digging, the problem was trigger when the system was under memory pressure
which cause a dramatic shrinkage in dcache entries. This shrinkage cause the
code path thats held under the BKL to be hit under a few filesystems (XFS, JFS
and EXT3).
At first glance, the BKL seem over kill since I don't see it protecting
anything that not already protected by other locks inside the code path. I
went ahead and removed the kernel lock from find_exported_dentry() and after
several hours of testing different loads and different filesystems I have yet
to see any kernel badness or
NFS call failures.
Is there anything in particular the BKL is trying to protect here or is it
safe to remove?
-JRS
-------------------------------------------------------
This SF.Net email is sponsored by: IBM Linux Tutorials
Free Linux tutorial presented by Daniel Robbins, President and CEO of
GenToo technologies. Learn everything from fundamentals to system
administration.http://ads.osdn.com/?ad_id=1470&alloc_id=3638&op=click
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next reply other threads:[~2004-03-09 14:01 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-03-09 13:54 Jose R. Santos [this message]
2004-03-11 21:10 ` BKL removal from find_exported_dentry() Jose R. Santos
2004-03-16 16:30 ` Jose R. Santos
2004-03-16 22:58 ` Neil Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20040309135451.GC30766@rx8.ibm.com \
--to=jrsantos@austin.ibm.com \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox