Linux NFS development
 help / color / mirror / Atom feed
From: Olaf Kirch <okir@suse.de>
To: nfs@lists.sourceforge.net
Subject: Small nfs-utils patch
Date: Mon, 23 May 2005 12:15:57 +0200	[thread overview]
Message-ID: <20050523101557.GD24634@suse.de> (raw)

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Without this patch, showmount -e would sometimes display
host names that should really have been subsumed under a
wildcard entry.

The problem was that the code in get_exportlist would always
skip the next group entry after removing one FQDN.

Olaf
-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
okir@suse.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax

[-- Attachment #2: nfs-utils-1.0.6-showmount.patch --]
[-- Type: text/plain, Size: 756 bytes --]


Without this patch, showmount -e would sometimes display
host names that should really have been subsumed under a
wildcard entry.

The problem was that the code in get_exportlist would always
skip the next group entry after removing one FQDN.

Signed-off-by: Olaf Kirch <okir@suse.de>

Index: nfs-utils-1.0.7/utils/mountd/mountd.c
===================================================================
--- nfs-utils-1.0.7.orig/utils/mountd/mountd.c
+++ nfs-utils-1.0.7/utils/mountd/mountd.c
@@ -409,11 +409,9 @@ get_exportlist(void)
 				xfree(c->gr_name);
 				xfree(c);
 				xfree (hp);
-				if ((c = *cp) == NULL)
-				  break;
+				continue;
 			      }
-			      else
-				xfree (hp);
+			      xfree (hp);
 			    }
 			    cp = &(c->gr_next);
 			  }

             reply	other threads:[~2005-05-23 10:16 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-05-23 10:15 Olaf Kirch [this message]
2005-10-07  4:47 ` Small nfs-utils patch Neil Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20050523101557.GD24634@suse.de \
    --to=okir@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox