Small nfs-utils patch

Small nfs-utils patch

[Olaf Kirch]

[-- Attachment #1: Type: text/plain, Size: 389 bytes --]

Without this patch, showmount -e would sometimes display
host names that should really have been subsumed under a
wildcard entry.

The problem was that the code in get_exportlist would always
skip the next group entry after removing one FQDN.

Olaf
-- 
Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
okir@suse.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax

[-- Attachment #2: nfs-utils-1.0.6-showmount.patch --]
[-- Type: text/plain, Size: 756 bytes --]


Without this patch, showmount -e would sometimes display
host names that should really have been subsumed under a
wildcard entry.

The problem was that the code in get_exportlist would always
skip the next group entry after removing one FQDN.

Signed-off-by: Olaf Kirch <okir@suse.de>

Index: nfs-utils-1.0.7/utils/mountd/mountd.c
===================================================================
--- nfs-utils-1.0.7.orig/utils/mountd/mountd.c
+++ nfs-utils-1.0.7/utils/mountd/mountd.c
@@ -409,11 +409,9 @@ get_exportlist(void)
 				xfree(c->gr_name);
 				xfree(c);
 				xfree (hp);
-				if ((c = *cp) == NULL)
-				  break;
+				continue;
 			      }
-			      else
-				xfree (hp);
+			      xfree (hp);
 			    }
 			    cp = &(c->gr_next);
 			  }

Re: Small nfs-utils patch

[Neil Brown]

On Monday May 23, okir@suse.de wrote:
> Without this patch, showmount -e would sometimes display
> host names that should really have been subsumed under a
> wildcard entry.
> 
> The problem was that the code in get_exportlist would always
> skip the next group entry after removing one FQDN.

Thanks.  I've committed it to the sourceforge CVS.
(Hey, turn-around of less than 5 months! You can't complain 
about that!! :-) 

NeilBrown

> 
> Olaf
> -- 
> Olaf Kirch   |  --- o --- Nous sommes du soleil we love when we play
> okir@suse.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax
> 
> Without this patch, showmount -e would sometimes display
> host names that should really have been subsumed under a
> wildcard entry.
> 
> The problem was that the code in get_exportlist would always
> skip the next group entry after removing one FQDN.
> 
> Signed-off-by: Olaf Kirch <okir@suse.de>
> 
> Index: nfs-utils-1.0.7/utils/mountd/mountd.c
> ===================================================================
> --- nfs-utils-1.0.7.orig/utils/mountd/mountd.c
> +++ nfs-utils-1.0.7/utils/mountd/mountd.c
> @@ -409,11 +409,9 @@ get_exportlist(void)
>  				xfree(c->gr_name);
>  				xfree(c);
>  				xfree (hp);
> -				if ((c = *cp) == NULL)
> -				  break;
> +				continue;
>  			      }
> -			      else
> -				xfree (hp);
> +			      xfree (hp);
>  			    }
>  			    cp = &(c->gr_next);
>  			  }


-------------------------------------------------------
This SF.Net email is sponsored by:
Power Architecture Resource Center: Free content, downloads, discussions,
and more. http://solutions.newsforge.com/ibmarch.tmpl
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs