From: Andrew Morton <akpm@osdl.org>
To: Greg Banks <gnb@melbourne.sgi.com>, Paul Jackson <pj@sgi.com>
Cc: Linux NFS Mailing List <nfs@lists.sourceforge.net>,
Zwane Mwaikambo <zwane@arm.linux.org.uk>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports
Date: Mon, 7 Aug 2006 20:39:14 -0700 [thread overview]
Message-ID: <20060807203914.6aec29df.akpm@osdl.org> (raw)
In-Reply-To: <1155007534.29877.215.camel@hole.melbourne.sgi.com>
On Tue, 08 Aug 2006 13:25:34 +1000
Greg Banks <gnb@melbourne.sgi.com> wrote:
> cpumask: use EXPORT_SYMBOL_GPL instead of EXPORT_SYMBOL to export
> node_2_cpu_mask. Thanks to Zwane Mwaikambo for pointing this out.
>
> Signed-off-by: Greg Banks <gnb@melbourne.sgi.com>
> ---
>
> arch/i386/kernel/smpboot.c | 2 +-
> 1 files changed, 1 insertion(+), 1 deletion(-)
>
> Index: linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> ===================================================================
> --- linux-2.6.18-rc2.orig/arch/i386/kernel/smpboot.c
> +++ linux-2.6.18-rc2/arch/i386/kernel/smpboot.c
> @@ -609,7 +609,7 @@ extern struct {
> /* which logical CPUs are on which nodes */
> cpumask_t node_2_cpu_mask[MAX_NUMNODES] __read_mostly =
> { [0 ... MAX_NUMNODES-1] = CPU_MASK_NONE };
> -EXPORT_SYMBOL(node_2_cpu_mask);
> +EXPORT_SYMBOL_GPL(node_2_cpu_mask);
> /* which node each logical CPU is on */
> int cpu_2_node[NR_CPUS] __read_mostly = { [0 ... NR_CPUS-1] = 0 };
> EXPORT_SYMBOL(cpu_2_node);
All the existing exports in lib/cpumask.c are EXPORT_SYMBOL() so I'd be
inclined to make any new exports match that.
<edits the diffs>
OK?
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2006-08-08 3:39 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-08 3:25 [PATCH 1 of 2] cpumask: use EXPORT_SYMBOL_GPL for new exports Greg Banks
2006-08-08 3:39 ` Andrew Morton [this message]
2006-08-08 3:40 ` Greg Banks
2006-08-08 3:48 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060807203914.6aec29df.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=gnb@melbourne.sgi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfs@lists.sourceforge.net \
--cc=pj@sgi.com \
--cc=zwane@arm.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox