From: "J. Bruce Fields" <bfields@fieldses.org>
To: Andrew Morton <akpm@osdl.org>
Cc: Neil Brown <neilb@suse.de>,
aime.le-rouzic@bull.net, nfs@lists.sourceforge.net,
Al Viro <viro@zeniv.linux.org.uk>,
Ingo Saitz <Ingo.Saitz@stud.uni-hannover.de>
Subject: [PATCH] nfsd: fix spurious error return from nfsd_create in async case
Date: Wed, 8 Nov 2006 19:49:09 -0500 [thread overview]
Message-ID: <20061109004909.GA30367@fieldses.org> (raw)
In-Reply-To: <20061108234515.GD16390@fieldses.org>
Commit 6264d69d7df654ca64f625e9409189a0e50734e9 modified the
nfsd_create() error handling in such a way that nfsd_create will usually
return nfserr_perm even when succesful, if the export has the async
export option.
This introduced a regression that could cause mkdir() to always return a
permissions error, even though the directory in question was actually
succesfully created.
Signed-off-by: J. Bruce Fields <bfields@citi.umich.edu>
diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
index 1a7ad8c..bb4d926 100644
--- a/fs/nfsd/vfs.c
+++ b/fs/nfsd/vfs.c
@@ -1177,7 +1177,7 @@ nfsd_create(struct svc_rqst *rqstp, stru
/*
* Get the dir op function pointer.
*/
- err = nfserr_perm;
+ err = 0;
switch (type) {
case S_IFREG:
host_err = vfs_create(dirp, dchild, iap->ia_mode, NULL);
-------------------------------------------------------------------------
Using Tomcat but need to do more? Need to support web services, security?
Get stuff done quickly with pre-integrated technology to make your job easier
Download IBM WebSphere Application Server v.1.0.1 based on Apache Geronimo
http://sel.as-us.falkag.net/sel?cmd=lnk&kid=120709&bid=263057&dat=121642
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2006-11-09 0:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-01 2:16 PROBLEM: can't mkdir() in 2.6.19-rc3 Ingo Saitz
2006-11-08 23:00 ` PROBLEM: can't mkdir() in 2.6.19-rc3 / 2.6.19-rc5 Ingo Saitz
2006-11-08 23:45 ` PROBLEM: can't mkdir() in 2.6.19-rc3 J. Bruce Fields
2006-11-09 0:49 ` J. Bruce Fields [this message]
2006-11-09 1:29 ` [PATCH] nfsd: fix spurious error return from nfsd_create in async case Neil Brown
2006-11-09 2:53 ` J. Bruce Fields
2006-11-09 1:35 ` PROBLEM: can't mkdir() in 2.6.19-rc3 Ingo Saitz
2006-11-09 2:52 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061109004909.GA30367@fieldses.org \
--to=bfields@fieldses.org \
--cc=Ingo.Saitz@stud.uni-hannover.de \
--cc=aime.le-rouzic@bull.net \
--cc=akpm@osdl.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox