Re: [PATCH 12/14] SUNRPC: RPC buffer size estimates are too large

["J. Bruce Fields" <bfields@fieldses.org>]

On Thu, Jan 18, 2007 at 06:30:53PM -0500, Chuck Lever wrote:
> The RPC buffer size estimation logic in net/sunrpc/clnt.c always
> significantly overestimates the requirements for the buffer size.
> A little instrumentation demonstrated that in fact rpc_malloc was never
> allocating the buffer from the mempool, but almost always called kmalloc.
> 
> To compute the size of the RPC buffer more precisely, split p_bufsiz into
> two fields; one for the argument size, and one for the result size.  The
> goal is to keep the size requirement for RPC buffers at or below 2KiB.
> 
> So now we will compute the sum of the exact call and reply header sizes,
> and split the RPC buffer precisely between the two.  That should keep all
> RPCs within the 2KiB buffer mempool limit.
> 
> And, we can finally be rid of RPC_SLACK_SPACE!

I'm a little worried about krb5, and especially the integrity and
privacy code--I don't think this accounts for the space they need.

I'm not sure how best to estimate their requirements....

--b.

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys - and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs