From mboxrd@z Thu Jan 1 00:00:00 1970 From: Christoph Hellwig Subject: Re: [PATCH 1/4 Revised] NLM - drop per fsid locks Date: Mon, 9 Apr 2007 19:49:02 +0100 Message-ID: <20070409184902.GA30444@infradead.org> References: <46156F60.1040400@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: cluster-devel@redhat.com, Lon Hohberger , nfs@lists.sourceforge.net To: Wendy Cheng Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1HayvI-0007Ek-RP for nfs@lists.sourceforge.net; Mon, 09 Apr 2007 11:49:04 -0700 Received: from pentafluge.infradead.org ([213.146.154.40]) by mail.sourceforge.net with esmtp (Exim 4.44) id 1HayvK-0000EF-2q for nfs@lists.sourceforge.net; Mon, 09 Apr 2007 11:49:07 -0700 In-Reply-To: <46156F60.1040400@redhat.com> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Thu, Apr 05, 2007 at 05:51:28PM -0400, Wendy Cheng wrote: > By writing exported filesytem id into /proc/fs/nfsd/nlm_unlock, this > patch walks thru lockd's global nlm_files list to release all the locks > associated with the particular id. It is used to enable NFS lock > failover with active-active clustered servers. > > Relevant steps: > 1) Exports filesystem with "fsid" option as: > /etc/exports entry> /mnt/shared/exports *(fsid=1234,sync,rw) > 2) Drops locks based on fsid by: > shell> echo 1234 > /proc/fs/nfsd/nlm_unlock This is a very awkward API. Dropping locks should support uuid or dev_t based exports aswell. Also it would be nice if you we had a more general push api for changes to filesystem state, that works on a similar basis as getting information from /etc/exports. And please inline your patches into the mail I send, attaching them makes it really hard to quote it in mail replies or even to simply read it. ------------------------------------------------------------------------- Take Surveys. Earn Cash. Influence the Future of IT Join SourceForge.net's Techsay panel and you'll get the chance to share your opinions on IT & business topics through brief surveys-and earn cash http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs