Re: [PATCH 2/4 Revised] NLM - set per fsid grace period

[Olaf Kirch <okir@lst.de>]

On Thursday 05 April 2007 23:52, Wendy Cheng wrote:
> This change enables per NFS-export entry lockd grace period. The 
> implementation is based on a double linked list fo_fsid_list that 
> contains entries of fsid info. It is expected this would not be a 
> frequent event. The fo_fsid_list is short and the entries expire within 
> a maximum of 50 seconds.  The grace period setting follows the existing 
> NLM grace period handling logic and is triggered via echoing the NFS 
> export filesystem id into nfsd procfs entry as:

Your patch creates a new per-export structure that is private to lockd.
It may be easier to put the grace period value into the export entry,
and check for that in nlm_fopen. It feels more natural than adding
a whole new shadow export table just for the benefit of lockd.
(Especially when you consider future extensions like being able
to search the list by dev_t or uuid or whatever)

Olaf
-- 
Olaf Kirch  |  --- o --- Nous sommes du soleil we love when we play
okir@lst.de |    / | \   sol.dhoop.naytheet.ah kin.ir.samse.qurax

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs