Re: [RFC,PATCH 2/14] knfsd: delete per transport

[Greg Banks <gnb@sgi.com>]

On Wed, May 16, 2007 at 04:51:23PM -0400, J. Bruce Fields wrote:
> Trivial comments, since I couldn't find any real problems:

Well, that's hopeful ;-)

> On Thu, May 17, 2007 at 05:19:51AM +1000, Greg Banks wrote:
> > @@ -886,7 +883,9 @@ svc_udp_sendto(struct svc_rqst *rqstp)
> >  static const struct svc_sock_ops svc_udp_ops = {
> >  	.sko_name = "udp",
> >  	.sko_recvfrom = svc_udp_recvfrom,
> > -	.sko_sendto = svc_udp_sendto
> > +	.sko_sendto = svc_udp_sendto,
> 
> Any objection to always just including a trailing comma and saving a
> little noise in each diff?  That seems to be common practice elsewhere.

Fixed.

> > +static void
> > +svc_tcpip_free(struct svc_sock *svsk)
> > +{
> > +	dprintk("svc: svc_sock_free(%p)\n", svsk);
> 
> We lived without these dprintk's before; do we need them now?

Not really.  Removed.

> >  	int			(*sko_sendto)(struct svc_rqst *rqstp);
> > +	/*
> > +	 * Detach the svc_sock from it's socket, so that the
> 
> s/it's/its/
> 

Doh!  Fixed.

Thanks Bruce.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs