From: Greg Banks <gnb@sgi.com>
To: Neil Brown <neilb@suse.de>
Cc: Thomas Talpey <Thomas.Talpey@netapp.com>,
Linux NFS Mailing List <nfs@lists.sourceforge.net>,
Peter Leckie <pleckie@melbourne.sgi.com>
Subject: Re: [RFC, PATCH 7/14] knfsd: export svc_sock_enqueue, svc_sock_received
Date: Fri, 18 May 2007 18:58:55 +1000 [thread overview]
Message-ID: <20070518085855.GL5104@sgi.com> (raw)
In-Reply-To: <17996.10983.101466.866944@notabene.brown>
On Thu, May 17, 2007 at 08:13:59PM +1000, Neil Brown wrote:
> On Thursday May 17, gnb@sgi.com wrote:
> > Index: linux/net/sunrpc/sunrpc_syms.c
> > ===================================================================
> > --- linux.orig/net/sunrpc/sunrpc_syms.c 2007-04-26 13:08:32.000000000 +1000
> > +++ linux/net/sunrpc/sunrpc_syms.c 2007-05-17 02:09:47.762054713 +1000
> > @@ -77,6 +77,8 @@ EXPORT_SYMBOL(svc_process);
> > EXPORT_SYMBOL(svc_recv);
> > EXPORT_SYMBOL(svc_wake_up);
> > EXPORT_SYMBOL(svc_makesock);
> > +EXPORT_SYMBOL_GPL(svc_sock_enqueue);
> > +EXPORT_SYMBOL_GPL(svc_sock_received);
> > EXPORT_SYMBOL(svc_reserve);
> > EXPORT_SYMBOL(svc_auth_register);
> > EXPORT_SYMBOL(auth_domain_lookup);
>
> Can we please put new EXPORT_SYMBOLS near the function rather than in
> this file?
Fixed, in all 3 patches which did this.
> And if anyone wants to move them all out, I'm fine with
> that.
>
There won't be much left of sunrpc_syms.c ;-)
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-05-18 8:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-05-16 19:24 [RFC, PATCH 7/14] knfsd: export svc_sock_enqueue, svc_sock_received Greg Banks
2007-05-16 21:17 ` J. Bruce Fields
2007-05-17 7:45 ` Greg Banks
2007-05-17 12:23 ` Talpey, Thomas
2007-05-17 10:13 ` Neil Brown
2007-05-18 8:58 ` Greg Banks [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070518085855.GL5104@sgi.com \
--to=gnb@sgi.com \
--cc=Thomas.Talpey@netapp.com \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=pleckie@melbourne.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox