Re: RFC: nlmclnt_grant() address check vs. callback address binding

[Frank van Maarseveen <frankvm@frankvm.com>]

On Tue, Jul 03, 2007 at 08:03:26AM -0400, Trond Myklebust wrote:
> On Tue, 2007-07-03 at 09:01 +0200, Frank van Maarseveen wrote:
> 
> > > There is _NO_ way for the client to figure out what lock the granted
> > > request refers to if the server starts transmitting from random IP
> > > addresses.
> > >       * There is no universal namespace for filehandles that can be used
> > >         to identify which file the granted request is meant for
> > >       * The cookie is not guaranteed to be the same as that sent by the
> > >         client for the LOCK request
> > >       * There is nothing else in the nlm_lock that can be used to
> > >         identify which file we're talking about.
> > 
> > The svid/pid. See nlm_find_lockowner().
> 
> nlm_find_lockowner() allocates a svid/pid that is unique only on a
> per-server basis.

Reading code... hmm, yes. One global 32 bit pid instead of one per server
would remove that problem. Note that this is still a very theoretical
problem because of all the other checks (filehandle check being the most
important one probably).

-- 
Frank

-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs