From: Frank van Maarseveen <frankvm@frankvm.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Linux NFS mailing list <nfs@lists.sourceforge.net>
Subject: Re: [PATCH 3/3] NLM: fix source address of callback to client
Date: Fri, 6 Jul 2007 17:27:14 +0200 [thread overview]
Message-ID: <20070706152714.GB18242@janus> (raw)
In-Reply-To: <20070706134404.GC10812@fieldses.org>
On Fri, Jul 06, 2007 at 09:44:04AM -0400, J. Bruce Fields wrote:
> On Thu, Jul 05, 2007 at 05:26:50PM +0200, Frank van Maarseveen wrote:
> > Use the destination address of the original NLM request as the
> > source address in callbacks to the client.
>
> What are the impliciations of changing nlm_lookup_host to also match on
> server ip address? (Doesn't that go beyond the minimum changes
> necessary just to get the source ip address right on grant callbacks?)
The address must be kept somewhere for creating a callback RPC request
later: the old request is gone by then. Multiple struct nlm_host per
client have always been possible because protocol and version must match
too so I can't find any problem with this.
--
Frank
-------------------------------------------------------------------------
This SF.net email is sponsored by DB2 Express
Download DB2 Express C - the FREE version of DB2 express and take
control of your XML. No limits. Just data. Click to get it now.
http://sourceforge.net/powerbar/db2/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-07-06 15:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-07-05 15:26 [PATCH 3/3] NLM: fix source address of callback to client Frank van Maarseveen
2007-07-06 13:44 ` J. Bruce Fields
2007-07-06 15:27 ` Frank van Maarseveen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070706152714.GB18242@janus \
--to=frankvm@frankvm.com \
--cc=bfields@fieldses.org \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox