From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH 013 of 20] knfsd: nfsd: factor out code from show_expflags Date: Fri, 13 Jul 2007 00:29:33 -0700 Message-ID: <20070713002933.f15724a7.akpm@linux-foundation.org> References: <20070710121949.12548.patches@notabene> <1070710022737.13509@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: "J. Bruce Fields" , nfs@lists.sourceforge.net, linux-kernel@vger.kernel.org To: NeilBrown Return-path: Received: from sc8-sf-mx1-b.sourceforge.net ([10.3.1.91] helo=mail.sourceforge.net) by sc8-sf-list2-new.sourceforge.net with esmtp (Exim 4.43) id 1I9Faz-0000KP-SY for nfs@lists.sourceforge.net; Fri, 13 Jul 2007 00:29:45 -0700 Received: from smtp2.linux-foundation.org ([207.189.120.14]) by mail.sourceforge.net with esmtps (TLSv1:AES256-SHA:256) (Exim 4.44) id 1I9Fb0-0005ju-O2 for nfs@lists.sourceforge.net; Fri, 13 Jul 2007 00:29:49 -0700 In-Reply-To: <1070710022737.13509@suse.de> List-Id: "Discussion of NFS under Linux development, interoperability, and testing." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfs-bounces@lists.sourceforge.net Errors-To: nfs-bounces@lists.sourceforge.net On Tue, 10 Jul 2007 12:27:37 +1000 NeilBrown wrote: > +static void exp_flags(struct seq_file *m, int flag, int fsid, > + uid_t anonu, uid_t anong, struct nfsd4_fs_locations *fsloc) > +{ > + show_expflags(m, flag, NFSEXP_ALLFLAGS); > if (flag & NFSEXP_FSID) > - seq_printf(m, "%sfsid=%d", first++?",":"", fsid); > + seq_printf(m, ",fsid=%d", fsid); > if (anonu != (uid_t)-2 && anonu != (0x10000-2)) > - seq_printf(m, "%sanonuid=%d", first++?",":"", anonu); > + seq_printf(m, ",sanonuid=%d", anonu); It's a bit presumptuous to print a uid_t with "%d". Fortunately it will work OK with all the present architectures. But in general: be cautious when feeding opaque types to printk. ------------------------------------------------------------------------- This SF.net email is sponsored by DB2 Express Download DB2 Express C - the FREE version of DB2 express and take control of your XML. No limits. Just data. Click to get it now. http://sourceforge.net/powerbar/db2/ _______________________________________________ NFS maillist - NFS@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/nfs