From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jeff Layton Subject: Re: [PATCH] NFS: have string-based mount options default to "intr" mounts Date: Wed, 25 Jul 2007 16:43:23 -0400 Message-ID: <20070725164323.d2cc9212.jlayton@redhat.com> References: <20070725145614.e17ca721.jlayton@redhat.com> <46A7A632.2050900@oracle.com> <20070725154107.063c3b9a.jlayton@redhat.com> <1185394617.6585.135.camel@localhost> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Cc: nfs@lists.sourceforge.net, nfsv4@linux-nfs.org To: Trond Myklebust Return-path: In-Reply-To: <1185394617.6585.135.camel@localhost> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: nfsv4-bounces@linux-nfs.org Errors-To: nfsv4-bounces@linux-nfs.org List-ID: On Wed, 25 Jul 2007 16:16:57 -0400 Trond Myklebust wrote: > On Wed, 2007-07-25 at 15:41 -0400, Jeff Layton wrote: > > On Wed, 25 Jul 2007 15:36:18 -0400 > > Chuck Lever wrote: > > > > > I thought "nointr" was the default because it is safest. > > > > > > > I could see maybe with soft mounts, but in conjunction with a hard > > mount (which is the default) is there danger of corruption? > > You may cause the sync to disk on close() to be aborted. The writes will > eventually get flushed to disk by the flushd() daemon, but failing to > sync writes to disk prior to closing the file is a violation of > close-to-open caching semantics and may cause corruption issues. > > Trond > The close would return EINTR in this case though, wouldn't it? The app should then be aware that it didn't actually happen and should reattempt it. Presuming that the app handles this correctly, is it really a data corruption issue? -- Jeff Layton