From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: Neil Brown <neilb@suse.de>, nfs@lists.sourceforge.net
Subject: Re: [RFC,PATCH 04/20] svc: xpt_has_wspace
Date: Wed, 29 Aug 2007 16:28:23 -0400 [thread overview]
Message-ID: <20070829202823.GA4687@fieldses.org> (raw)
In-Reply-To: <1188418276.7502.29.camel@trinity.ogc.int>
On Wed, Aug 29, 2007 at 03:11:16PM -0500, Tom Tucker wrote:
> This code combines checks for listening endpoints and connected
> endpoints in the same function (_has_wspace).
Ah, thanks! Sorry, I totally missed the TCP_LISTEN checks before the
setting of SK_CONN.
> Perhaps I don't understand the nuances fully, but since all the terms in
> the condition are AND, they will all be tested and unless there is a
> race I'm missing the order doesn't matter.
Yes, makes sense to me.
> In any event, I think it would be easier to understand if we broken the
> tests up into two if-statements with a simple comment for each.
Sure. And maybe a block comment someplace explaining the use of
SK_CONN?
--b.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
prev parent reply other threads:[~2007-08-29 20:28 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-08-20 16:20 [RFC,PATCH 00/20] svc: Server Side Transport Switch Tom Tucker
2007-08-20 16:23 ` [RFC, PATCH 01/20] svc: Add svc_xprt transport switch structure Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 02/20] svc: xpt_detach and xpt_free Tom Tucker
2007-08-29 17:05 ` Chuck Lever
2007-08-29 17:08 ` J. Bruce Fields
2007-08-20 16:23 ` [RFC,PATCH 03/20] svc: xpt_prep_reply_hdr Tom Tucker
2007-08-29 17:15 ` Chuck Lever
2007-08-29 18:28 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 05/20] svc: xpt_max_payload Tom Tucker
2007-08-29 17:40 ` Chuck Lever
2007-08-29 19:06 ` Tom Tucker
2007-08-20 16:23 ` [RFC, PATCH 06/20] svc: export svc_sock_enqueue, svc_sock_received Tom Tucker
2007-08-21 16:03 ` Chuck Lever
2007-08-21 18:08 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 07/20] svc: centralise close handling Tom Tucker
2007-08-29 18:16 ` Chuck Lever
2007-08-20 16:23 ` [RFC,PATCH 08/20] svc: centralise accept handling Tom Tucker
2007-08-29 18:40 ` Chuck Lever
2007-08-29 23:56 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 09/20] svc: Add SK_LISTENER flag Tom Tucker
2007-08-29 18:41 ` Chuck Lever
2007-08-20 16:23 ` [RFC,PATCH 10/20] svc: Add generic refcount services Tom Tucker
2007-08-29 18:55 ` Chuck Lever
2007-08-29 20:19 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 11/20] svc: cleanup svc_sock initialization Tom Tucker
2007-08-29 19:07 ` Chuck Lever
2007-08-20 16:23 ` [RFC,PATCH 13/20] svc: Add svc_[un]register_transport Tom Tucker
2007-08-29 19:12 ` Chuck Lever
2007-08-29 20:32 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 14/20] svc: Register TCP/UDP Transports Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 15/20] svc: transport file implementation Tom Tucker
2007-08-29 19:15 ` Chuck Lever
2007-08-29 20:37 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 16/20] svc: xpt_create_svc Tom Tucker
2007-08-29 19:21 ` Chuck Lever
2007-08-29 20:43 ` Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 17/20] svc: Add xpt_get_name service Tom Tucker
2007-08-20 16:23 ` [RFC,PATCH 18/20] svc: Add xpt_defer transport function Tom Tucker
2007-08-29 19:29 ` Chuck Lever
2007-08-29 21:34 ` Tom Tucker
2007-08-20 16:24 ` [RFC,PATCH 19/20] knfsd: call svc_create_svcsock Tom Tucker
2007-08-20 16:24 ` [RFC,PATCH 20/20] knfsd: create listener via portlist write Tom Tucker
2007-08-29 16:50 ` [RFC,PATCH 00/20] svc: Server Side Transport Switch Chuck Lever
2007-08-29 17:01 ` Talpey, Thomas
2007-08-29 17:59 ` Tom Tucker
2007-08-30 21:12 ` Chuck Lever
2007-08-31 1:19 ` Talpey, Thomas
2007-08-29 16:55 ` J. Bruce Fields
[not found] ` <20070820162329.15224.29032.stgit@dell3.ogc.int>
2007-08-29 17:32 ` [RFC,PATCH 04/20] svc: xpt_has_wspace Chuck Lever
2007-08-29 18:50 ` Tom Tucker
2007-08-29 17:35 ` J. Bruce Fields
2007-08-29 18:52 ` Tom Tucker
2007-08-29 18:53 ` J. Bruce Fields
2007-08-29 19:31 ` J. Bruce Fields
2007-08-29 20:11 ` Tom Tucker
2007-08-29 20:26 ` Tom Tucker
2007-08-29 20:29 ` J. Bruce Fields
2007-08-29 20:28 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070829202823.GA4687@fieldses.org \
--to=bfields@fieldses.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox