From: Greg Banks <gnb@sgi.com>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: Question about svc_age_temp_sockets
Date: Fri, 14 Sep 2007 19:16:44 +1000 [thread overview]
Message-ID: <20070914091644.GD21965@sgi.com> (raw)
In-Reply-To: <C30998A8.138C0%tom@opengridcomputing.com>
On Sun, Sep 09, 2007 at 12:33:44PM -0500, Tom Tucker wrote:
>
> I'm confused about how svc_age_temp_sockets is supposed to work. [...]
> - There's a check for a zero sk_inuse count. I don't see a legitimate way
> for a socket to be on the tempsocks list with a zero refcount.
>
> Am I just hopelessly confused here or is this code broken?
When the code was written, the natural idle state of a svcsock
was sk_inuse == 0. Later, in commit
http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=commitdiff;h=aaf68cfbf2241d24d46583423f6bff5c47e088b3
Neil changed this so the natural idle state is sk_inuse == 1 and
the sk_inuse == 0 condition only happens transiently during socket
shutdown. This is a far better design, but it seems the check
in svc_age_temp_sockets() wasn't updated at the time and is now
dead code. It could probably be removed.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-09-14 9:16 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-09 17:33 Question about svc_age_temp_sockets Tom Tucker
2007-09-14 9:16 ` Greg Banks [this message]
-- strict thread matches above, loose matches on Subject: below --
2007-09-10 8:33 Wolfgang Walter
2007-09-10 14:04 ` Tom Tucker
2007-09-14 9:19 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070914091644.GD21965@sgi.com \
--to=gnb@sgi.com \
--cc=nfs@lists.sourceforge.net \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox