From: Greg Banks <gnb@sgi.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: Neil Brown <neilb@suse.de>, nfs@lists.sourceforge.net
Subject: Re: [PATCH] knfsd: remove unnecessary BUG_ON's
Date: Sat, 15 Sep 2007 02:40:58 +1000 [thread overview]
Message-ID: <20070914164058.GK21965@sgi.com> (raw)
In-Reply-To: <20070912234317.GF13792@fieldses.org>
On Wed, Sep 12, 2007 at 07:43:17PM -0400, J. Bruce Fields wrote:
> Trivial patch, but--any objection to removing these assertions?
>
> We set svsk->sk_pool = pool just 30-some lines above, and there's no
> obvious reason this should have changed, or any other particular reason
> to assert this here.
Yeah, you'd think that. However we saw these BUG_ON()s tripped
when attempting to port the 2.6.18-based NFS/RDMA patches to a
2.6.19-like kernel. All it takes is for some transport code to get
confused about the proper way to clear SK_BUSY, and *blam*. So I
think they're useful.
Greg.
--
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere. Which MPHG character are you?
I don't speak for SGI.
-------------------------------------------------------------------------
This SF.net email is sponsored by: Microsoft
Defy all challenges. Microsoft(R) Visual Studio 2005.
http://clk.atdmt.com/MRT/go/vse0120000070mrt/direct/01/
_______________________________________________
NFS maillist - NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs
next prev parent reply other threads:[~2007-09-14 16:40 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-09-12 23:43 [PATCH] knfsd: remove unnecessary BUG_ON's J. Bruce Fields
2007-09-14 16:40 ` Greg Banks [this message]
2007-09-14 16:50 ` J. Bruce Fields
2007-09-14 16:58 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070914164058.GK21965@sgi.com \
--to=gnb@sgi.com \
--cc=bfields@fieldses.org \
--cc=neilb@suse.de \
--cc=nfs@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox