Re: [RFC, PATCH] svc: Modify svc_create_xprt to return local port

[Greg Banks <gnb@sgi.com>]

On Tue, Oct 09, 2007 at 05:52:53PM -0500, Tom Tucker wrote:
> 
> Please take this version of the patch. The previous version has a
> whitespace issue. Sorry for the inconvenience.
> 
> This patch fixes a regression introduced by the svc transport
> switch as follows:
> 
> - Listening endpoints need to have their local address set properly. 
> 
> - svc_create_xprt needs to return the local port number since the
>   the nfs4 callback service uses the return value to determine the 
>   local port elected by the transport when binding to zero.
> 
> [...]
> --- a/net/sunrpc/svcsock.c
> +++ b/net/sunrpc/svcsock.c
> @@ -1278,6 +1278,8 @@ svc_create_socket(struct svc_serv *serv,
>  	int		error;
>  	int		type;
>  	char		buf[RPC_MAX_ADDRBUFLEN];
> +	struct sockaddr	newsin;
> +	int		newlen;

Struct sockaddr isn't big enough for this to work with ipv6,
use struct sockaddr_storage.  Or do the kernel_getsockname()
driectly into xprt->xpt_local.

Greg.
-- 
Greg Banks, R&D Software Engineer, SGI Australian Software Group.
Apparently, I'm Bedevere.  Which MPHG character are you?
I don't speak for SGI.

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs