Linux NFS development
 help / color / mirror / Atom feed
From: Tom Tucker <tom@opengridcomputing.com>
To: nfs@lists.sourceforge.net
Cc: bfields@fieldses.org, neilb@suse.de, gnb@sgi.com
Subject: [RFC, PATCH 4/4] svc: Move svc_xprt_received call to follow addition of xprt to list
Date: Fri, 19 Oct 2007 16:45:30 -0500	[thread overview]
Message-ID: <20071019214530.31422.4899.stgit@dell3.ogc.int> (raw)
In-Reply-To: <20071019214058.31422.35615.stgit@dell3.ogc.int>


The call to svc_xprt_received function should be called after the transport 
is completely initialized and added to the tempsocks list.

Signed-off-by: Tom Tucker <tom@opengridcomputing.com>
---

 net/sunrpc/svc_xprt.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/net/sunrpc/svc_xprt.c b/net/sunrpc/svc_xprt.c
index 6b2c73c..bb007e7 100644
--- a/net/sunrpc/svc_xprt.c
+++ b/net/sunrpc/svc_xprt.c
@@ -615,7 +615,6 @@ int svc_recv(struct svc_rqst *rqstp, lon
 		struct svc_xprt *newxpt;
 		newxpt = xprt->xpt_ops->xpo_accept(xprt);
 		if (newxpt) {
-			svc_xprt_received(newxpt);
 			/*
 			 * We know this module_get will succeed because the
 			 * listener holds a reference too
@@ -634,6 +633,7 @@ int svc_recv(struct svc_rqst *rqstp, lon
 					  jiffies + svc_conn_age_period * HZ);
 			}
 			spin_unlock_bh(&serv->sv_lock);
+			svc_xprt_received(newxpt);
 		}
 		svc_xprt_received(xprt);
 	} else {

-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems?  Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs

      parent reply	other threads:[~2007-10-19 21:45 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-19 21:40 [RFC, PATCH 0/4] svc: New transport bugs found porting svcrdma Tom Tucker
2007-10-19 21:45 ` [RFC, PATCH 1/4] svc: Fix skip computation in svc_defer and svc_revisit Tom Tucker
2007-10-23  2:45   ` Greg Banks
2007-10-23  3:11     ` Tom Tucker
2007-10-23  3:52       ` Greg Banks
2007-10-23 18:03     ` J. Bruce Fields
2007-10-24  2:45       ` Greg Banks
2007-10-24  2:53         ` J. Bruce Fields
2007-10-19 21:45 ` [RFC, PATCH 2/4] svc: svc_addsock needs to set the svc_xprt address Tom Tucker
2007-10-22  7:15   ` Greg Banks
2007-10-19 21:45 ` [RFC, PATCH 3/4] svc: Add svc_xprt_names service to replace svc_sock_names Tom Tucker
2007-10-19 21:45 ` Tom Tucker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071019214530.31422.4899.stgit@dell3.ogc.int \
    --to=tom@opengridcomputing.com \
    --cc=bfields@fieldses.org \
    --cc=gnb@sgi.com \
    --cc=neilb@suse.de \
    --cc=nfs@lists.sourceforge.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox