From: Christoph Hellwig <hch@infradead.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org,
nfsv4@linux-nfs.org
Subject: Re: [PATCH 2/6] SUNRPC: Break up __svc_create_thread and make svc_create_kthread
Date: Thu, 13 Dec 2007 21:06:44 +0000 [thread overview]
Message-ID: <20071213210643.GA28117@infradead.org> (raw)
In-Reply-To: <1197578428-26815-3-git-send-email-jlayton@redhat.com>
On Thu, Dec 13, 2007 at 03:40:24PM -0500, Jeff Layton wrote:
> Move the initialization that happens prior to thread creation to a new
> function (svc_prepare_thread) so that we can call it from a new thread
> creation routine. Add a new function svc_create_kthread that spawns svc
> threads using kthread API.
>
> We should be able to eventually convert all of the callers to the
> kthread API, at which point we can drop __svc_create_thread.
> +static struct svc_rqst *
> +svc_prepare_thread(svc_thread_fn func, struct svc_serv *serv,
> + struct svc_pool *pool)
Could you just export this helper? I'd rather have callers have full
control over how they create their threads and call into a helper to
initialize the sunrpc state.
next prev parent reply other threads:[~2007-12-13 21:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 20:40 [PATCH 0/6] Intro: convert lockd to kthread and fix use-after-free Jeff Layton
2007-12-13 20:40 ` [PATCH 1/6] SUNRPC: Allow svc_pool_map_set_cpumask to work with any task Jeff Layton
2007-12-13 20:40 ` [PATCH 2/6] SUNRPC: Break up __svc_create_thread and make svc_create_kthread Jeff Layton
2007-12-13 20:40 ` [PATCH 3/6] NLM: Initialize completion variable in lockd_up Jeff Layton
2007-12-13 20:40 ` [PATCH 4/6] NLM: Have lockd call try_to_freeze Jeff Layton
2007-12-13 20:40 ` [PATCH 5/6] NLM: Convert lockd to use kthreads Jeff Layton
2007-12-13 20:40 ` [PATCH 6/6] NLM: Add reference counting to lockd Jeff Layton
2007-12-13 21:06 ` Christoph Hellwig [this message]
2007-12-13 21:18 ` [PATCH 2/6] SUNRPC: Break up __svc_create_thread and make svc_create_kthread Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071213210643.GA28117@infradead.org \
--to=hch@infradead.org \
--cc=jlayton@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox