From: Jeff Layton <jlayton@redhat.com>
To: "J. Bruce Fields" <bfields@fieldses.org>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/3] NLM: Convert lockd to use kthreads
Date: Mon, 11 Feb 2008 10:33:13 -0500 [thread overview]
Message-ID: <20080211103313.0e3bb207@tleilax.poochiereds.net> (raw)
In-Reply-To: <20080211152938.GF25742@fieldses.org>
On Mon, 11 Feb 2008 10:29:38 -0500
"J. Bruce Fields" <bfields@fieldses.org> wrote:
> Oops, did I forget to send this? I don't' see it in the archives.
> Apologies:
>
> On Mon, Feb 11, 2008 at 12:22:08AM +0000, bfields wrote:
> > On Thu, Feb 07, 2008 at 04:34:55PM -0500, Jeff Layton wrote:
> > ...
> > > diff --git a/fs/lockd/svc.c b/fs/lockd/svc.c
> > > index 0822646..378b393 100644
> > > --- a/fs/lockd/svc.c
> > > +++ b/fs/lockd/svc.c
> > ...
> > > @@ -174,6 +167,10 @@ lockd(struct svc_rqst *rqstp)
> > > } else if (time_before(grace_period_expire, jiffies))
> > > clear_grace_period();
> > >
> > > + /* nlmsvc_retry_blocked can block, so check for kthread_stop */
> > > + if (kthread_should_stop())
> > > + break;
> >
> > The following svc_recv call will check kthread_should_stop() pretty
> > early on, so I don't believe this is necessary?
> >
> > Assuming that's correct, I've deleted these lines and applied the rest.
> >
Sounds reasonable...ACK
--
Jeff Layton <jlayton@redhat.com>
next prev parent reply other threads:[~2008-02-11 15:33 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-11 15:29 [PATCH 3/3] NLM: Convert lockd to use kthreads J. Bruce Fields
2008-02-11 15:33 ` Jeff Layton [this message]
-- strict thread matches above, loose matches on Subject: below --
2008-02-07 21:34 [PATCH 0/3] NLM: convert lockd to kthreads (try #11) Jeff Layton
2008-02-07 21:34 ` [PATCH 1/3] SUNRPC: export svc_sock_update_bufs Jeff Layton
2008-02-07 21:34 ` [PATCH 2/3] SUNRPC: have svc_recv() check kthread_should_stop() Jeff Layton
2008-02-07 21:34 ` [PATCH 3/3] NLM: Convert lockd to use kthreads Jeff Layton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080211103313.0e3bb207@tleilax.poochiereds.net \
--to=jlayton@redhat.com \
--cc=bfields@fieldses.org \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).