From: "Steinar H. Gunderson" <sgunderson-jG/AHqQBv7lBDgjK7y7TUQ@public.gmane.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: retry= is additive with the text-based mount interface
Date: Fri, 25 Apr 2008 18:59:21 +0200 [thread overview]
Message-ID: <20080425165921.GA7108@uio.no> (raw)
In-Reply-To: <F4C3F5C0-1D60-4285-9CB3-171C70C96B03@oracle.com>
On Fri, Apr 25, 2008 at 12:45:36PM -0400, Chuck Lever wrote:
>> fugl:~# mount -t nfs -v -o retry=0 10.0.0.11:/foo /mnt
>> mount.nfs: timeout set for Thu Jan 1 14:40:25 1970
>> mount.nfs: text-based options: 'retry=0,addr=10.0.0.11'
> On my test system (Fedora 7) I get correct behavior with both /bin/mount
> and when using /sbin/mount.nfs directly.
It seems the patch has an issue:
+ if (!parse_retry_option(&timeout, options, NFS_DEF_FG_TIMEOUT_MINUTES))
where parse_retry_option() _adds_ to timeout. But timeout is not initialized :-)
/* Steinar */
--
Homepage: http://www.sesse.net/
next prev parent reply other threads:[~2008-04-25 16:59 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-04-25 8:05 retry= is additive with the text-based mount interface Steinar H. Gunderson
[not found] ` <20080425080535.GA4999-6Z/AllhyZU4@public.gmane.org>
2008-04-25 16:20 ` Chuck Lever
2008-04-25 16:34 ` Steinar H. Gunderson
[not found] ` <20080425163457.GA6952-6Z/AllhyZU4@public.gmane.org>
2008-04-25 16:45 ` Chuck Lever
2008-04-25 16:59 ` Steinar H. Gunderson [this message]
[not found] ` <20080425165921.GA7108-6Z/AllhyZU4@public.gmane.org>
2008-04-25 17:05 ` Trond Myklebust
2008-04-25 17:11 ` Chuck Lever
2008-04-25 17:38 ` Steinar H. Gunderson
[not found] ` <20080425173833.GA7306-6Z/AllhyZU4@public.gmane.org>
2008-04-25 20:37 ` Chuck Lever
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080425165921.GA7108@uio.no \
--to=sgunderson-jg/ahqqbv7lbdgjk7y7tuq@public.gmane.org \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox