From: "J. Bruce Fields" <bfields@fieldses.org>
To: Tom Tucker <tom@opengridcomputing.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-nfs <linux-nfs@vger.kernel.org>
Subject: Re: [PATCH] svcrdma: Fix compile warning on 32b platforms
Date: Sun, 25 May 2008 15:01:12 -0400 [thread overview]
Message-ID: <20080525190112.GC8094@fieldses.org> (raw)
In-Reply-To: <1211557193.4114.21.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
On Fri, May 23, 2008 at 10:39:53AM -0500, Tom Tucker wrote:
> The ib_sge is used to store both dma_addr_t and virtual addresses.
> This causes a warning on 32b platforms when casting ptrs to the
> u64 addr field of the ib_sge. There is work underway to reduce the
> memory footprint of the WR context in 2.6.27 the time frame that will
> remove the overloading of the ib_sge.addr field.
Naively, this and "svcrdma: Refactor RDMA_WRITE dma mapping logic" still
look like a step in the wrong direction; the old code seemed to have a
much more clear separation between kernel addresses (void *'s) and
on-the-wire addresses (stored in u64's). Stuff like:
> + (void*)(unsigned long)
> + sge[i].addr, sge[i].length,
makes me nervous.
--b.
next prev parent reply other threads:[~2008-05-25 19:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 15:39 [PATCH] svcrdma: Fix compile warning on 32b platforms Tom Tucker
[not found] ` <1211557193.4114.21.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org>
2008-05-25 19:01 ` J. Bruce Fields [this message]
2008-05-25 20:21 ` J. Bruce Fields
[not found] ` <C45F878E.19918%tom@opengridcomputing.com>
2008-05-28 19:07 ` J. Bruce Fields
2008-05-28 19:49 ` Tom Tucker
2008-05-27 14:08 ` Tom Tucker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080525190112.GC8094@fieldses.org \
--to=bfields@fieldses.org \
--cc=akpm@linux-foundation.org \
--cc=linux-nfs@vger.kernel.org \
--cc=tom@opengridcomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox