From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH] svcrdma: Initialize the context free list for listeners Date: Sun, 25 May 2008 15:03:57 -0400 Message-ID: <20080525190357.GE8094@fieldses.org> References: <1211556779.4114.17.camel@trinity.ogc.int> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs To: Tom Tucker Return-path: Received: from mail.fieldses.org ([66.93.2.214]:33391 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1757388AbYEYTD6 (ORCPT ); Sun, 25 May 2008 15:03:58 -0400 In-Reply-To: <1211556779.4114.17.camel-SMNkleLxa3ZimH42XvhXlA@public.gmane.org> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Fri, May 23, 2008 at 10:32:59AM -0500, Tom Tucker wrote: > Move the initialization of the sc_ctxt_free list to the > client/listener generic bit of the init logic. This is > necessary to avoid a bug check when shutting down a listening > endpoint when list debug is enabled. This bug was introduced > when the context cache was converted to use Linux lists. OK.--b. > > Signed-off-by: Tom Tucker > --- > net/sunrpc/xprtrdma/svc_rdma_transport.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c > index 54b2126..2c2f5f6 100644 > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c > @@ -446,7 +446,6 @@ static void create_context_cache(struct svcxprt_rdma *xprt, > xprt->sc_ctxt_cnt = 0; > atomic_set(&xprt->sc_ctxt_used, 0); > > - INIT_LIST_HEAD(&xprt->sc_ctxt_free); > for (i = 0; i < ctxt_count; i++) { > ctxt = kmalloc(sizeof(*ctxt), GFP_KERNEL); > if (ctxt) { > @@ -496,6 +495,7 @@ static struct svcxprt_rdma *rdma_create_xprt(struct svc_serv *serv, > atomic_set(&cma_xprt->sc_sq_count, 0); > atomic_set(&cma_xprt->sc_ctxt_used, 0); > > + INIT_LIST_HEAD(&cma_xprt->sc_ctxt_free); > if (!listener) { > int reqs = cma_xprt->sc_max_requests; > create_context_cache(cma_xprt, >