Re: [PATCH 2/6] rpc: timeout patch

["J. Bruce Fields" <bfields@fieldses.org>]

On Mon, Jun 09, 2008 at 05:18:50PM -0400, Trond Myklebust wrote:
> On Mon, 2008-06-09 at 16:51 -0400, J. Bruce Fields wrote:
> > From: Olga Kornievskaia <aglo@citi.umich.edu>
> > 
> > When a client gss upcall times out, we currently give a mesage reminding
> > the user to check whether gssd is running.
> > 
> > Currently gssd only listens on pipes under nfs/.  We expect to modify it
> > so it treats all clients the same regardless of protocol (as it probably
> > should have before), and new functionality may depend on that.  So
> > people may need to upgrade gssd to get such new functionality.
> > 
> > So it would be helpful if the error message specified which pipe exactly
> > the upcall was failing on, and suggested that the problem could be due
> > to an outdated gssd (not just a non-existant gssd).
> 
> NACK. I belive I've already made clear that I really don't like the idea
> of using d_path() in an error message.
> 
> Please just correct the existing error message to remind people that
> they need an up to date version of gssd, and add a comment in Kconfig
> stating exactly _which_ minimal version is needed.

Actually, after another look, maybe we should just do nothing:

The most likely next user of this is the nfsv4 callbacks.  But callbacks
aren't that crucial: if someone doesn't care about delegations, and
wants to delay upgrading gssd, they should be able to do that without
their server's logs getting spammed all the time.

So I'm inclined to just drop this--apologies.

--b.