From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org, gnb@melbourne.sgi.com
Subject: Re: [PATCH 4/5] knfsd: convert knfsd to kthread API
Date: Tue, 10 Jun 2008 12:25:26 -0400 [thread overview]
Message-ID: <20080610162526.GE20184@fieldses.org> (raw)
In-Reply-To: <20080610162426.GD20184@fieldses.org>
On Tue, Jun 10, 2008 at 12:24:26PM -0400, bfields wrote:
> On Tue, Jun 10, 2008 at 08:40:38AM -0400, Jeff Layton wrote:
> In fact, I don't think you really need to take a reference till there's
> a chance the new thread will decrement the reference--and since the
> first thing the new thread does is take the mutex (which we're also
> holding here), you could wait till after the succesful kthread_create()
> to take the reference. But maybe that's more fragile. So I'd just
> move the module_get to right before the kthread_create().
Anyway, that's very minor, and this all seems OK otherwise, so I might
make this one small modification and just apply if there's no further
comments.
--b.
next prev parent reply other threads:[~2008-06-10 16:25 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-10 12:40 [PATCH 0/5] Convert knfsd to kthread API and fix startup/shutdown races (try #4) Jeff Layton
2008-06-10 12:40 ` [PATCH 1/5] knfsd: Replace lock_kernel with a mutex for nfsd thread startup/shutdown locking Jeff Layton
2008-06-10 12:40 ` [PATCH 2/5] knfsd: clean up nfsd filesystem interfaces Jeff Layton
2008-06-10 12:40 ` [PATCH 3/5] knfsd: remove special handling for SIGHUP Jeff Layton
2008-06-10 12:40 ` [PATCH 4/5] knfsd: convert knfsd to kthread API Jeff Layton
2008-06-10 12:40 ` [PATCH 5/5] sunrpc: remove sv_kill_signal field from svc_serv struct Jeff Layton
2008-06-10 16:24 ` [PATCH 4/5] knfsd: convert knfsd to kthread API J. Bruce Fields
2008-06-10 16:25 ` J. Bruce Fields [this message]
2008-06-10 17:06 ` Jeff Layton
2008-06-10 20:05 ` J. Bruce Fields
2008-06-10 20:19 ` Jeff Layton
2008-06-12 3:38 ` [PATCH 1/5] knfsd: Replace lock_kernel with a mutex for nfsd thread startup/shutdown locking Neil Brown
2008-06-12 12:37 ` Jeff Layton
2008-06-13 6:12 ` Neil Brown
2008-06-13 18:04 ` J. Bruce Fields
-- strict thread matches above, loose matches on Subject: below --
2008-06-06 15:12 [PATCH 0/5] Convert knfsd to kthread API and fix startup/shutdown races (try #3) Jeff Layton
2008-06-06 15:12 ` [PATCH 1/5] knfsd: Replace lock_kernel with a mutex for nfsd thread startup/shutdown locking Jeff Layton
2008-06-06 15:12 ` [PATCH 2/5] knfsd: clean up nfsd filesystem interfaces Jeff Layton
2008-06-06 15:12 ` [PATCH 3/5] knfsd: remove special handling for SIGHUP Jeff Layton
2008-06-06 15:12 ` [PATCH 4/5] knfsd: convert knfsd to kthread API Jeff Layton
2008-06-06 17:24 ` J. Bruce Fields
2008-06-06 18:11 ` Jeff Layton
2008-06-06 18:16 ` J. Bruce Fields
2008-06-06 19:05 ` Jeff Layton
[not found] ` <20080606150537.14c9537c-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-06-06 19:13 ` J. Bruce Fields
2008-06-06 19:49 ` Jeff Layton
[not found] ` <20080606154948.303aba28-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-06-09 13:08 ` J. Bruce Fields
2008-06-09 13:19 ` Jeff Layton
[not found] ` <20080609091948.0b2b19a9-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-06-09 18:39 ` J. Bruce Fields
2008-06-09 18:54 ` Jeff Layton
[not found] ` <20080609145459.1adda51a-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-06-10 10:50 ` Greg Banks
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080610162526.GE20184@fieldses.org \
--to=bfields@fieldses.org \
--cc=gnb@melbourne.sgi.com \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox