Re: [PATCH] NFSD: fix use of setsockopt

["J. Bruce Fields" <bfields@fieldses.org>]

On Wed, Jun 25, 2008 at 04:44:15PM -0400, Olga Kornievskaia wrote:
> Looking at the kernel code, when setsockopt() is called on a UDP socket  
> to set send/receive buffer for UPD the code will not do anything:  
> udp_setsockopt() and udp_lib_setsockopt() will return -ENOPROTOOPT.  
> However, we bypass the call to setsockopt() and instead set the buffer  
> sizes directly. From what I understand sk_sndbuf/sk_rcvbuf are not used  
> by the UDP code. We are setting the fields that are never used.
>
> Then perhaps we can remove calls to svc_sock_setbufsize() from  
> svc_udp_init() and svc_udp_recvfrom()?

Assuming you're correct about udp not using those fields (haven't
checked myself)--yes, that'd be great.

--b.