Linux NFS development
 help / color / mirror / Atom feed
From: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>
To: linux-nfs@vger.kernel.org
Subject: [PATCH] nfs: sysctl's should use USER_HZ not HZ
Date: Tue, 1 Jul 2008 11:44:29 -0700	[thread overview]
Message-ID: <20080701114429.539d7fb0@extreme> (raw)

There is no good way to tell what the internal value of kernel HZ is
from userspace, so all administrative interfaces are supposed to use
either USER_HZ (100) or other absolute time units.  Two of the NFS sysctl
values are still using HZ, and can be simply converted to USER_HZ.

Signed-off-by: Stephen Hemminger <shemminger-ZtmgI6mnKB3QT0dZR+AlfA@public.gmane.org>

--- a/fs/nfs/sysctl.c	2008-07-01 11:37:13.000000000 -0700
+++ b/fs/nfs/sysctl.c	2008-07-01 11:38:21.000000000 -0700
@@ -37,7 +37,7 @@ static ctl_table nfs_cb_sysctls[] = {
 		.data = &nfs_idmap_cache_timeout,
 		.maxlen = sizeof(int),
 		.mode = 0644,
-		.proc_handler = &proc_dointvec_jiffies,
+		.proc_handler = &proc_dointvec_userhz_jiffies,
 		.strategy = &sysctl_jiffies,
 	},
 #endif
@@ -47,7 +47,7 @@ static ctl_table nfs_cb_sysctls[] = {
 		.data		= &nfs_mountpoint_expiry_timeout,
 		.maxlen		= sizeof(nfs_mountpoint_expiry_timeout),
 		.mode		= 0644,
-		.proc_handler	= &proc_dointvec_jiffies,
+		.proc_handler	= &proc_dointvec_userhz_jiffies,
 		.strategy	= &sysctl_jiffies,
 	},
 	{

             reply	other threads:[~2008-07-01 18:44 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-01 18:44 Stephen Hemminger [this message]
2008-07-01 18:50 ` [PATCH] nfs: sysctl's should use USER_HZ not HZ Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080701114429.539d7fb0@extreme \
    --to=shemminger-ztmgi6mnkb3qt0dzr+alfa@public.gmane.org \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox