From: "J. Bruce Fields" <bfields@fieldses.org>
To: Benny Halevy <bhalevy@panasas.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] nfsd: take file and mnt write in nfs4_upgrade_open
Date: Tue, 8 Jul 2008 10:35:36 -0400 [thread overview]
Message-ID: <20080708143535.GA7032@fieldses.org> (raw)
In-Reply-To: <48732271.4080206@panasas.com>
On Tue, Jul 08, 2008 at 11:16:49AM +0300, Benny Halevy wrote:
> On Jul. 07, 2008, 22:25 +0300, "J. Bruce Fields" <bfields@fieldses.org> wrote:
> > Yes, this looks correct, at least for the immediate fix; thanks!
> >
> > Eventually I think we should move to opening a new file descriptor when
> > upgrading, and keeping two file descriptors with the stateid; I think
> > this business of trying to use a file descriptor for write when we
> > opened it for read is probably wrong.
>
> That could work, though they need to be associated in some way
> for open_downgrade/close processing.
Yes. I think it would work just to keep up to one read-only open and
one write-only open and then close one or the other as necessary on the
downgrade.
--b.
next prev parent reply other threads:[~2008-07-08 14:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-03 12:21 writeable file with no mnt_want_write() Benny Halevy
2008-07-03 20:36 ` J. Bruce Fields
2008-07-04 12:34 ` Benny Halevy
2008-07-04 12:38 ` [PATCH] nfsd: take file and mnt write in nfs4_upgrade_open Benny Halevy
2008-07-07 19:25 ` J. Bruce Fields
2008-07-08 8:16 ` Benny Halevy
2008-07-08 14:35 ` J. Bruce Fields [this message]
2008-07-07 19:05 ` writeable file with no mnt_want_write() J. Bruce Fields
2008-07-08 8:40 ` Benny Halevy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080708143535.GA7032@fieldses.org \
--to=bfields@fieldses.org \
--cc=bhalevy@panasas.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox