Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Dilip Kumar <udilipkumar@gmail.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: Bug in NFSV3 ACCESS Procedure reply
Date: Thu, 28 Aug 2008 20:27:34 -0400	[thread overview]
Message-ID: <20080829002734.GA20109@fieldses.org> (raw)
In-Reply-To: <9344d2ec0808281422v13ed6af9gc0f91569d52ca3be-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Thu, Aug 28, 2008 at 02:22:35PM -0700, Dilip Kumar wrote:
> I was writing some scripts to map the Unix access modes to the access
> flags in the NFS ACCESS Reply. I have run these scripts on Linux and
> Solaris machines and the results were not the same. If I have some C
> program which opens this directory in a write mode exported by an NFS
> server it succeeds, if the server is Solaris, but fails if the server
> is Linux. If I have write access on the directory, I would expect to
> see write bit set for that directory in the ACCESS reply. Programs
> like mkdir or cd require execute and write access to complete their
> operations, but a normal open with write mode should succeed in either
> case. I was more concerned about the differences in the implementation
> of ACCESS in two different servers.

Behavior that's different from Solaris probably merits investigation,
but on its own that's not justification for making a change.

It sounds like this isn't a real problem for you, just a result you
observed in some tests, so for now I'm not inclined to worry about it
very much.  If you want to pursue it, you're welcome to make a patch
(it's probably just a matter of adjusting those accessmap arrays in
fs/nfsd/vfs.c), and you may well be correct to do so, but the patch will
need to come with a more persuasive argument.

--b.

      parent reply	other threads:[~2008-08-29  0:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-08-27 19:41 Bug in NFSV3 ACCESS Procedure reply Dilip Kumar
     [not found] ` <9344d2ec0808271241x375a4d86r6cfa7c10beb905c8-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-28 17:34   ` J. Bruce Fields
2008-08-28 17:41     ` Dilip Kumar
     [not found]       ` <9344d2ec0808281041w15e2738ew546531398f80a312-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-28 17:49         ` J. Bruce Fields
2008-08-28 17:52           ` Dilip Kumar
     [not found]             ` <9344d2ec0808281052s71efeeebh81fea6805b6eef10-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-28 18:54               ` J. Bruce Fields
2008-08-28 21:22                 ` Dilip Kumar
     [not found]                   ` <9344d2ec0808281422v13ed6af9gc0f91569d52ca3be-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-08-29  0:27                     ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080829002734.GA20109@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=linux-nfs@vger.kernel.org \
    --cc=udilipkumar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox