From mboxrd@z Thu Jan 1 00:00:00 1970 From: "J. Bruce Fields" Subject: Re: [PATCH 08/10] lockd: struct nlm_reboot should contain a full socket address Date: Wed, 1 Oct 2008 16:55:20 -0400 Message-ID: <20081001205520.GH10937@fieldses.org> References: <20080917161337.4963.74674.stgit@ellison.1015granger.net> <20080917161811.4963.60224.stgit@ellison.1015granger.net> <20080926230938.GK7138@fieldses.org> <20081001181801.GF6001@fieldses.org> <59C7F69A-58EA-41F9-888E-C11039302755@oracle.com> <20081001200839.GB10937@fieldses.org> <20081001203305.GD10937@fieldses.org> <33D15870-F84F-42BE-B938-C792BC86B174@oracle.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: linux-nfs@vger.kernel.org To: Chuck Lever Return-path: Received: from mail.fieldses.org ([66.93.2.214]:51340 "EHLO fieldses.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752332AbYJAUzV (ORCPT ); Wed, 1 Oct 2008 16:55:21 -0400 In-Reply-To: <33D15870-F84F-42BE-B938-C792BC86B174@oracle.com> Sender: linux-nfs-owner@vger.kernel.org List-ID: On Wed, Oct 01, 2008 at 04:48:41PM -0400, Chuck Lever wrote: > On Oct 1, 2008, at Oct 1, 2008, 4:33 PM, J. Bruce Fields wrote: >> And from a quick look at nfs-utils/statd/ it certainly looks to me >> like >> it's correctly treating the contents as a totally opaque object. > > That's exactly what happens. The cookie field is generated by the > SM_MON upcall, and passed back by the SM_NOTIFY downcall. OK, that's great. So we can just - Choose whatever contents for the "priv"/cookie field we want to keep the lookup on receipt of SM_NOTIFY easy, and - remove the support for ipv6 on the loopback communication with statd; we don't need it. >> So I think we can put whatever we want in the priv field--an ipv6 >> address, an index into some kernel table, whatever. (The priv field >> shouldn't even have to make sense to a future boot instance--we don't >> need to be notified of previously monitored hosts' reboots any more >> once >> we've rebooted ourselves.) > > Apparently, then, rpc.statd doesn't have enough knowledge to make the > downcall via IPv6 when needed. Everything we need to look up the host > must be encoded into the 16-byte opaque field. > > I'll look into it. Thanks! --b.