Re: [PATCH] sunrpc: make warning in svc_check_conn_limits() more generic

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Oct 17, 2008 at 02:27:53PM -0400, Jeff Layton wrote:
> On Fri, 17 Oct 2008 14:20:51 -0400
> "J. Bruce Fields" <bfields@fieldses.org> wrote:
> 
> > > A per-service setting that defaults to something reasonable like your
> > > suggestions and can be over-ridden by a module parameter sounds like a
> > > good idea.
> > > If you change the module parameter via
> > >  /sys/modules/lockd/parameters/max_connections
> > > then it wouldn't take effect until the service were stopped and restarted,
> > > but I expect that is acceptable (and could probably be 'fixed' if really
> > > needed).
> > 
> > Sounds fine to me.
> > 
> > And I'd probably fix the defaults now and then hold off adding
> > max_connections till it'd been seen to be needed.
> > 
> > --b.
> 
> I just posted a small patchset that implements this. I ended up adding
> a module parameter for it since it was easy to do. I've only done basic
> smoke testing with it, however. If it looks OK, I'll see if I can get
> the guy who originally reported this to test it out.

Thanks!  I'll take a look.

--b.