Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Krishna Kumar <krkumar2@in.ibm.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH 3/4] nfsd: Fix leaked memory in nfs4_make_rec_clidname
Date: Mon, 20 Oct 2008 16:58:42 -0400	[thread overview]
Message-ID: <20081020205842.GC27702@fieldses.org> (raw)
In-Reply-To: <20081020061709.18370.85373.sendpatchset-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>

On Mon, Oct 20, 2008 at 11:47:09AM +0530, Krishna Kumar wrote:
> From: Krishna Kumar <krkumar2@in.ibm.com>
> 
> cksum.data is not freed up in one error case. Compile tested.
> 

Thanks, applied.

--b.

> Signed-off-by: Krishna Kumar <krkumar2@in.ibm.com>
> ---
> 
>  fs/nfsd/nfs4recover.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -ruNp linux-2.6.27.org/fs/nfsd/nfs4recover.c linux-2.6.27.new/fs/nfsd/nfs4recover.c
> --- linux-2.6.27.org/fs/nfsd/nfs4recover.c	2008-10-20 10:47:15.000000000 +0530
> +++ linux-2.6.27.new/fs/nfsd/nfs4recover.c	2008-10-20 10:48:38.000000000 +0530
> @@ -110,9 +110,9 @@ nfs4_make_rec_clidname(char *dname, stru
>  
>  	md5_to_hex(dname, cksum.data);
>  
> -	kfree(cksum.data);
>  	status = nfs_ok;
>  out:
> +	kfree(cksum.data);
>  	crypto_free_hash(desc.tfm);
>  out_no_tfm:
>  	return status;
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2008-10-20 20:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-20  6:17 [PATCH 3/4] nfsd: Fix leaked memory in nfs4_make_rec_clidname Krishna Kumar
     [not found] ` <20081020061709.18370.85373.sendpatchset-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-10-20  6:17   ` [PATCH 4/4] nfsd: Minor cleanup of _get_posix_acl Krishna Kumar
     [not found]     ` <20081020061721.18370.93671.sendpatchset-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2008-10-20 21:02       ` J. Bruce Fields
2008-10-20 20:58   ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081020205842.GC27702@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=krkumar2@in.ibm.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox