Re: [PATCH 13/14] NLM: Remove "create" argument from nsm_find()

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Oct 24, 2008 at 02:11:23PM -0400, Chuck Lever wrote:
> Clean up: nsm_find() now has only one caller who always sets the

Clearer to say: "now only has one caller, and that caller always
sets...".

> "create" argument, so it is no longer needed.  Since nsm_find() now
> has a more specific function, pick a more appropriate name for it.
...
> -struct nsm_handle *nsm_find(const struct sockaddr *sap, const size_t salen,
> -			    const char *hostname, const size_t hostname_len,
> -			    const int create)
> +struct nsm_handle *nsm_get_handle(const struct sockaddr *sap,
> +				  const size_t salen, const char *hostname,
> +				  const size_t hostname_len)
>  {

Maybe "nsm_create_handle" would be even clearer?  (It doesn't just
increment a reference counter.)

--b.