Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Steve Dickson <SteveD@redhat.com>
Cc: Frank van Maarseveen <frankvm@frankvm.com>,
	Linux NFS mailing list <linux-nfs@vger.kernel.org>,
	Neil Brown <neilb@suse.de>
Subject: Re: nfs-utils 1.1.2 + knfsd 2.6.27 (.5) breaks fsid= option
Date: Sun, 16 Nov 2008 16:57:00 -0500	[thread overview]
Message-ID: <20081116215700.GB25834@fieldses.org> (raw)
In-Reply-To: <20081116200211.GK21551@fieldses.org>

On Sun, Nov 16, 2008 at 03:02:11PM -0500, bfields wrote:
> On Wed, Nov 12, 2008 at 08:48:47AM -0500, Steve Dickson wrote:
> > Frank van Maarseveen wrote:
> > > Tested on Debian lenny with nfs-kernel-server 1:1.1.2-6lenny1 and a
> > > 2.6.27.5 kernel. /etc/exports says:
> > > 
> > > 	/mp @general(rw,sync,no_root_squash,no_subtree_check,mp,fsid=2886795869)
> > > 
> > > After actually using it /proc/fs/nfsd/exports says:
> > > 
> > > 	/mp @general(rw,no_root_squash,sync,wdelay,no_subtree_check,fsid=-1408171427,uuid=db4387a6:bed949d0:8f5ef6a2:6a0c
> > > 
> > > (yes, 2886795869 == (ulong)-1408171427)
> > > However, file handles over the wire now seem to have fsid_type=6
> > > (FSID_UUID16) instead of 1 (FSID_NUM) due to this.
> > 
> > This is a known problem... The kernel checks UUIDs before FSIDS which cause
> > FSIDS to be ignored. There are two outstanding proposals to fix this problem.
> >    1) Move two lines in the kernel so FSIDs are checked before UUIDS
> >    2) Change mountd to only send down  the FSID or the UUID but
> >       not both as it does today.
> >  
> > Neither proposal has been accepted... yet...
> 
> I'd have a mild preference for the 2nd,

Maybe I should take that back--Neil, don't we need to pass down the uuid
to match the client-provided filehandle type in the case where they're
giving us uuid-style filehandles?  In that case we need to pass down
both so the kernel can choose the desired one.  So if we need to fix
this then that would make SteveD's patch the way to go.

--b.

  parent reply	other threads:[~2008-11-16 21:57 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-12 10:48 nfs-utils 1.1.2 + knfsd 2.6.27 (.5) breaks fsid= option Frank van Maarseveen
2008-11-12 13:48 ` Steve Dickson
     [not found]   ` <491ADEBF.80900-AfCzQyP5zfLQT0dZR+AlfA@public.gmane.org>
2008-11-16 20:02     ` J. Bruce Fields
2008-11-16 20:29       ` Frank van Maarseveen
2008-11-16 21:59         ` J. Bruce Fields
2008-11-16 21:57       ` J. Bruce Fields [this message]
2008-11-17  0:52         ` NeilBrown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081116215700.GB25834@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=SteveD@redhat.com \
    --cc=frankvm@frankvm.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=neilb@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox