From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: Kevin Coffman <kwc@umich.edu>,
linux-nfs@vger.kernel.org, nfsv4@linux-nfs.org
Subject: Re: possible module refcount leak with auth_gss
Date: Wed, 10 Dec 2008 11:31:36 -0500 [thread overview]
Message-ID: <20081210163136.GB28263@fieldses.org> (raw)
In-Reply-To: <20081210112506.2b2d2c3a@tleilax.poochiereds.net>
On Wed, Dec 10, 2008 at 11:25:06AM -0500, Jeff Layton wrote:
> It works. With a nfs-utils that has your patches to properly set the
> cache timeouts it looks like this problem is generally fixed. The module
> refcounts go back to normal once the tickets expire.
>
> That said, I think we should have a look at Bruce's suggestion for changing
> the way that the module refcounts are actually handled. It would seem to
> make more sense to hold the reference based on the exports using that auth
> scheme, and to purge the caches on module unload.
>
> Not a huge deal, but probably something we should consider.
Yeah. Since I don't care enough about module unloading, I'm not going
to work on this now. But it's unfortunate.
I'm a little more worried about why the RPC_GSS_PROC_DESTROY requests
aren't working.
--b.
next prev parent reply other threads:[~2008-12-10 16:31 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-08 15:28 possible module refcount leak with auth_gss Jeff Layton
[not found] ` <20081208102855.30081708-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-12-08 17:37 ` J. Bruce Fields
2008-12-09 20:38 ` Jeff Layton
[not found] ` <20081209153849.6605559a-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-12-09 23:21 ` Kevin Coffman
[not found] ` <4d569c330812091521s6b9405faq910cb94f067f3b-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2008-12-10 16:25 ` Jeff Layton
2008-12-10 16:31 ` J. Bruce Fields [this message]
2008-12-16 21:45 ` Jeff Layton
[not found] ` <20081216164532.22cab9d6-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-12-17 2:40 ` Jeff Layton
2008-12-17 19:20 ` J. Bruce Fields
2008-12-17 19:34 ` Jeff Layton
[not found] ` <20081217143458.080aa9be-RtJpwOs3+0O+kQycOl6kW4xkIHaj4LzF@public.gmane.org>
2008-12-17 19:41 ` J. Bruce Fields
2008-12-17 19:54 ` Trond Myklebust
2008-12-17 20:07 ` J. Bruce Fields
2008-12-17 20:09 ` J. Bruce Fields
2008-12-17 20:10 ` Trond Myklebust
2008-12-17 19:38 ` Trond Myklebust
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081210163136.GB28263@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=kwc@umich.edu \
--cc=linux-nfs@vger.kernel.org \
--cc=nfsv4@linux-nfs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox