Re: [PATCH 10/27] NSM: Remove !nsm check from nsm_release()

["J. Bruce Fields" <bfields@fieldses.org>]

On Fri, Dec 05, 2008 at 07:03:09PM -0500, Chuck Lever wrote:
> The nsm_release() function should never be called with a NULL handle
> point.  If it is, that's a bug.

OK, both applied.--b.

> 
> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
> ---
> 
>  fs/lockd/mon.c |    2 --
>  1 files changed, 0 insertions(+), 2 deletions(-)
> 
> diff --git a/fs/lockd/mon.c b/fs/lockd/mon.c
> index f3ae631..c2f4607 100644
> --- a/fs/lockd/mon.c
> +++ b/fs/lockd/mon.c
> @@ -288,8 +288,6 @@ retry:
>   */
>  void nsm_release(struct nsm_handle *nsm)
>  {
> -	if (!nsm)
> -		return;
>  	if (atomic_dec_and_lock(&nsm->sm_count, &nsm_lock)) {
>  		list_del(&nsm->sm_link);
>  		spin_unlock(&nsm_lock);
>