From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: aime.le-rouzic@bull.net, linux-nfs@vger.kernel.org
Subject: Re: [PATCH 05/22] NFSD: Add helper functions for __write_ports()
Date: Mon, 29 Dec 2008 13:42:33 -0500 [thread overview]
Message-ID: <20081229184233.GC13756@fieldses.org> (raw)
In-Reply-To: <722B1063-9532-4F1C-9214-C7D9DFF3CA3F@oracle.com>
On Mon, Dec 29, 2008 at 12:04:29PM -0500, Chuck Lever wrote:
> On Dec 24, 2008, at Dec 24, 2008, 11:15 PM, J. Bruce Fields wrote:
>> On Fri, Dec 12, 2008 at 04:57:42PM -0500, Chuck Lever wrote:
>>> Clean up: I'd like to refactor __write_ports() to make it easier to
>>> understand and maintain. Introduce a set of helper functions to
>>> handle the details of the __write_ports() function.
>>>
>>> New helpers are not used yet.
>>
>> As stated in http://marc.info/?l=linux-nfs&m=122894134032274&w=2, I'd
>> prefer that new code be introduced with its callers where reasonable,
>> so
>> in this case I'd rather this patch be combined with the following.
>
> Right, I wrote these patches well before the referenced e-mail, and
> split them this way because the diff of the combined changes is well-
> nigh impossible to read.
>
> What I may end up doing instead is splitting these helpers out one patch
> at a time. That should make for more legible patches.
Yes, I think that's the more natural split.
--b.
next prev parent reply other threads:[~2008-12-29 18:42 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-12 21:57 [PATCH 00/22] IPv6 support NFSD Chuck Lever
[not found] ` <20081212215340.24332.88416.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-12-12 21:57 ` [PATCH 01/22] NFSD: clean up failover sysctl function naming Chuck Lever
2008-12-12 21:57 ` [PATCH 02/22] NFSD: Fix a handful of coding style issues in write_filehandle() Chuck Lever
2008-12-12 21:57 ` [PATCH 03/22] NFSD: Replace open-coded integer with macro Chuck Lever
2008-12-12 21:57 ` [PATCH 04/22] NFSD: Add documenting comments for nfsctl interface Chuck Lever
2008-12-12 21:57 ` [PATCH 05/22] NFSD: Add helper functions for __write_ports() Chuck Lever
[not found] ` <20081212215742.24332.36578.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-12-25 4:15 ` J. Bruce Fields
2008-12-29 17:04 ` Chuck Lever
2008-12-29 18:42 ` J. Bruce Fields [this message]
2008-12-12 21:57 ` [PATCH 06/22] NFSD: Refactor __write_ports() Chuck Lever
2008-12-12 21:57 ` [PATCH 07/22] NFSD: Prevent a buffer overflow in svc_xprt_names() Chuck Lever
[not found] ` <20081212215757.24332.77904.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-12-25 4:32 ` J. Bruce Fields
2008-12-12 21:58 ` [PATCH 08/22] SUNRPC: pass buffer size to svc_addsock() and svc_sock_names() Chuck Lever
[not found] ` <20081212215804.24332.24605.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-12-14 17:33 ` Tom Tucker
2008-12-15 16:40 ` Chuck Lever
2008-12-15 21:05 ` Tom Tucker
2008-12-15 21:17 ` J. Bruce Fields
2008-12-25 4:43 ` J. Bruce Fields
2008-12-29 19:24 ` Chuck Lever
2008-12-30 19:38 ` J. Bruce Fields
2008-12-12 21:58 ` [PATCH 09/22] SUNRPC: Switch one_sock_name() to use snprintf() Chuck Lever
2008-12-12 21:58 ` [PATCH 10/22] SUNRPC: Support AF_INET6 in one_sock_name() Chuck Lever
2008-12-12 21:58 ` [PATCH 11/22] SUNRPC: Clean up one_sock_name() Chuck Lever
2008-12-12 21:58 ` [PATCH 12/22] NFSD: Support AF_INET6 in svc_addsock() function Chuck Lever
2008-12-12 21:58 ` [PATCH 13/22] NFS: Move NFS client's IP address parser to nfs_common/ Chuck Lever
[not found] ` <20081212215842.24332.47093.stgit-07a7zB5ZJzbwdl/1UfZZQIVfYA8g3rJ/@public.gmane.org>
2008-12-25 4:47 ` J. Bruce Fields
2008-12-12 21:58 ` [PATCH 14/22] NFSD: Support IPv6 addresses in write_failover_ip() Chuck Lever
2008-12-12 21:58 ` [PATCH 15/22] NFSD: Enable NFS server use of AF_INET6 Chuck Lever
2008-12-12 21:59 ` [PATCH 16/22] NFSD: Prevent buffer overflow in write_threads() Chuck Lever
2008-12-12 21:59 ` [PATCH 17/22] NFSD: Prevent buffer overflow in write_versions() Chuck Lever
2008-12-12 21:59 ` [PATCH 18/22] NFSD: Prevent buffer overflow in write_maxblksize() Chuck Lever
2008-12-12 21:59 ` [PATCH 19/22] NFSD: Prevent buffer overflow in write_leasetime() Chuck Lever
2008-12-12 21:59 ` [PATCH 20/22] NFSD: Prevent buffer overflow in write_recoverydir() Chuck Lever
2008-12-12 21:59 ` [PATCH 21/22] NLM: Refactor make_socks() function Chuck Lever
2008-12-12 21:59 ` [PATCH 22/22] NLM: Clean up flow of control in " Chuck Lever
2008-12-16 16:53 ` [PATCH 00/22] IPv6 support NFSD J. Bruce Fields
2008-12-25 5:01 ` J. Bruce Fields
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081229184233.GC13756@fieldses.org \
--to=bfields@fieldses.org \
--cc=aime.le-rouzic@bull.net \
--cc=chuck.lever@oracle.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox