public inbox for linux-nfs@vger.kernel.org
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Chuck Lever <chuck.lever@oracle.com>
Cc: Linux NFS Mailing list <linux-nfs@vger.kernel.org>
Subject: Re: [basic] nfsd failing to start
Date: Mon, 12 Jan 2009 22:34:56 -0500	[thread overview]
Message-ID: <20090113033456.GA15650@fieldses.org> (raw)
In-Reply-To: <81C79F78-751B-405C-BF61-9FFD903909A3@oracle.com>

On Mon, Jan 12, 2009 at 06:04:59PM -0500, Chuck Lever wrote:
> On Jan 12, 2009, at 5:29 PM, J. Bruce Fields wrote:
>> None of this is in contradiction to what you've said--it's a
>> tradeoff--but on balance I'd prefer the additional svc_register()  
>> logic.
>
> We really do want a hard switch to be able to turn this new feature off.
>
> It's impossible for the kernel to detect which version of rpcbind is  
> running.  Yes, it can tell if rpcbind v4 is supported or not, but what  
> if some versions of rpcbind have a bug or exhibit some incompatible or  
> undesirable behavior?  We have already required an incompatible rev of  
> rpcbind once in the last six months because of bugs.

I'd consider that acceptable; we just use the highest protocol version,
and deal with the problem of buggy userspace separately.

> Because we have to support distributions like Ubuntu and Debian, which  
> package basically what is in upstream without a lot of testing, we have 
> to allow them to flip a switch to get the desired legacy behavior, while 
> still permitting users who want to experiment to do so without a lot of 
> trouble.  It's also in the best interest of our kernel community which 
> you mention above.

Another way users and distributors could flip that switch would be by
varying the choice of userland daemon to install and run.  Then flipping
the switch would not require a kernel change.

> Transitioning user space will be an effort for all distributions.  This 
> CONFIG switch was added so they could do that without worrying about 
> their existing NFS implementation suddenly breaking after a kernel 
> upgrade.  When/if it does misbehave, it is simply a matter of disabling 
> one config option to restore order.

"apt-get remove rpcbind", for example, will often be more convenient
than replacing the kernel.

> It would probably be easy to add some logic that detects a protocol  
> version mismatch, and then prints a clearer error message.  That's what I 
> had in mind to address bz 12256.  But this is never going to be perfect 
> while user space IPv6 support is under development and in transition.

Thanks, I agree that that would be an improvement.

I can't demand the runtime protocol-version switching at this point.  I
still would consider it a further improvement, though, if someone had
the time to work on it.

--b.

      reply	other threads:[~2009-01-13  3:34 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-11 21:41 [basic] nfsd failing to start Harry P
     [not found] ` <87zlhxy102.fsf-kFrNdAxtuftBDgjK7y7TUQ@public.gmane.org>
2009-01-12 17:24   ` J. Bruce Fields
2009-01-12 21:09     ` Harry P
2009-01-12 21:29       ` Chuck Lever
2009-01-12 22:00         ` J. Bruce Fields
2009-01-12 22:14     ` Chuck Lever
2009-01-12 22:29       ` J. Bruce Fields
2009-01-12 23:04         ` Chuck Lever
2009-01-13  3:34           ` J. Bruce Fields [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090113033456.GA15650@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-nfs@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox