From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Jaswinder Singh Rajput <jaswinder@kernel.org>
Cc: Ingo Molnar <mingo@elte.hu>, x86 maintainers <x86@kernel.org>,
urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org,
linux-media@vger.kernel.org, netfilter-devel@vger.kernel.org,
netfilter@vger.kernel.org, bfields@fieldses.org, neilb@suse.de,
linux-nfs@vger.kernel.org, linux-raid@vger.kernel.org,
dbrownell@users.sourceforge.net,
spi-devel-general@lists.sourceforge.net, netdev@vger.kernel.org,
greg@kroah.com, linux-usb@vger.kernel.org, dwmw2@infradead.org,
linux-mtd@lists.infradead.org, tiwai@suse.de,
mchehab@infradead.org, LKML <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [GIT PULL -tip] fix 33 make headers_check warnings
Date: Mon, 19 Jan 2009 11:24:29 +1100 [thread overview]
Message-ID: <20090119112429.78f5dc33.sfr@canb.auug.org.au> (raw)
In-Reply-To: <1232223441.3966.22.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 1059 bytes --]
On Sun, 18 Jan 2009 01:47:21 +0530 Jaswinder Singh Rajput <jaswinder@kernel.org> wrote:
>
> diff --git a/include/linux/nfsd/stats.h b/include/linux/nfsd/stats.h
> index 7678cfb..0b53cfe 100644
> --- a/include/linux/nfsd/stats.h
> +++ b/include/linux/nfsd/stats.h
> @@ -29,9 +29,11 @@ struct nfsd_stats {
> unsigned int ra_size; /* size of ra cache */
> unsigned int ra_depth[11]; /* number of times ra entry was found that deep
> * in the cache (10percentiles). [10] = not found */
> +#ifdef __KERNEL__
> #ifdef CONFIG_NFSD_V4
> unsigned int nfs4_opcount[LAST_NFS4_OP + 1]; /* count of individual nfsv4 operations */
> #endif
> +#endif /* __KERNEL__ */
>
> };
The only variable in the kernel of type "struct nfsd_stats" is only
exported to user mode via procfs, so this whole structure could probably
go inside __KERNEL__. Then looking harder, I wonder if this header
should be exported to user mode at all.
--
Cheers,
Stephen Rothwell sfr@canb.auug.org.au
http://www.canb.auug.org.au/~sfr/
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2009-01-19 0:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-01-17 20:17 [GIT PULL -tip] fix 33 make headers_check warnings Jaswinder Singh Rajput
[not found] ` <1232223441.3966.22.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-17 21:37 ` David Woodhouse
2009-01-17 22:04 ` Jan Engelhardt
2009-01-17 22:19 ` Sam Ravnborg
2009-01-17 22:23 ` David Woodhouse
[not found] ` <1232230980.27094.15.camel-uXGAPMMVk8bAQYKIod7YupZV94DADvEd@public.gmane.org>
2009-01-18 2:46 ` Jaswinder Singh Rajput
2009-01-17 22:26 ` H. Peter Anvin
2009-01-21 0:38 ` Jaswinder Singh Rajput
2009-01-23 15:59 ` Jaswinder Singh Rajput
2009-01-23 16:04 ` Jaswinder Singh Rajput
2009-01-23 16:11 ` Jan Engelhardt
[not found] ` <alpine.LSU.2.00.0901231710350.15413-vVwEwcwQeYFPkBl3ERsXe1l1cybopEuJUBSOeVevoDU@public.gmane.org>
2009-01-23 16:21 ` Sam Ravnborg
2009-01-23 16:31 ` Jaswinder Singh Rajput
[not found] ` <1232728304.3504.28.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-23 17:09 ` Sam Ravnborg
2009-01-23 17:28 ` Jaswinder Singh Rajput
2009-01-23 21:33 ` H. Peter Anvin
2009-01-23 21:54 ` Jan Engelhardt
2009-01-23 22:01 ` H. Peter Anvin
2009-01-18 3:05 ` Jaswinder Singh Rajput
2009-01-18 3:33 ` Kyle McMartin
[not found] ` <20090118033339.GA671-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2009-01-18 3:38 ` Jaswinder Singh Rajput
[not found] ` <1232249904.3097.15.camel-bi+AKbBUZKY6gyzm1THtWbp2dZbC/Bob@public.gmane.org>
2009-01-18 4:18 ` Kyle McMartin
[not found] ` <20090118041800.GB671-PfSpb0PWhxZc2C7mugBRk2EX/6BAtgUQ@public.gmane.org>
2009-01-23 15:56 ` Jaswinder Singh Rajput
2009-01-18 9:13 ` Ingo Molnar
2009-01-18 10:10 ` Sam Ravnborg
2009-01-19 0:24 ` Stephen Rothwell [this message]
2009-01-19 2:53 ` Jaswinder Singh Rajput
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090119112429.78f5dc33.sfr@canb.auug.org.au \
--to=sfr@canb.auug.org.au \
--cc=akpm@linux-foundation.org \
--cc=bfields@fieldses.org \
--cc=dbrownell@users.sourceforge.net \
--cc=dwmw2@infradead.org \
--cc=greg@kroah.com \
--cc=jaswinder@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=linux-nfs@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=mingo@elte.hu \
--cc=neilb@suse.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=oliver.hartkopp-l29pVbxQd1IUtdQbppsyvg@public.gmane.org \
--cc=spi-devel-general@lists.sourceforge.net \
--cc=tiwai@suse.de \
--cc=urs.thuermann-l29pVbxQd1IUtdQbppsyvg@public.gmane.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox