Linux NFS development
 help / color / mirror / Atom feed
From: "J. Bruce Fields" <bfields@fieldses.org>
To: Manish Katiyar <mkatiyar@gmail.com>
Cc: kmsmith@umich.edu, kandros@umich.edu, linux-nfs@vger.kernel.org,
	akpm@linux-foundation.org
Subject: Re: [PATCH] : Fix compilation warnings in fs/nfsd/nfs4state.c
Date: Wed, 28 Jan 2009 14:11:04 -0500	[thread overview]
Message-ID: <20090128191104.GA6276@fieldses.org> (raw)
In-Reply-To: <ea11fea30901272238t4d11ba15t8bac4cd702ea7440-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

On Wed, Jan 28, 2009 at 12:08:19PM +0530, Manish Katiyar wrote:
> Below patch removes the following warning ;-
> fs/nfsd/nfs4state.c:1657: warning: unused variable 'flp'

I don't believe we want to support a .config with NFS or NFSD turned on
but CONFIG_FILE_LOCKING off.

--b.

> 
> 
> Signed-off-by: Manish Katiyar <mkatiyar@gmail.com>
> ---
>  fs/nfsd/nfs4state.c |    5 ++++-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
> index 69e98ca..2903589 100644
> --- a/fs/nfsd/nfs4state.c
> +++ b/fs/nfsd/nfs4state.c
> @@ -1654,7 +1654,10 @@ nfs4_open_delegation(struct svc_fh *fh, struct
> nfsd4_open *open, struct nfs4_sta
>  	struct nfs4_delegation *dp;
>  	struct nfs4_stateowner *sop = stp->st_stateowner;
>  	struct nfs4_callback *cb = &sop->so_client->cl_callback;
> -	struct file_lock fl, *flp = &fl;
> +	struct file_lock fl;
> +#ifdef CONFIG_FILE_LOCKING
> +	struct file_lock *flp = &fl;
> +#endif
>  	int status, flag = 0;
> 
>  	flag = NFS4_OPEN_DELEGATE_NONE;
> -- 
> 1.5.4.3
> 
> 
> Thanks -
> Manish
> --
> To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

  parent reply	other threads:[~2009-01-28 19:11 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-28  6:38 [PATCH] : Fix compilation warnings in fs/nfsd/nfs4state.c Manish Katiyar
     [not found] ` <ea11fea30901272238t4d11ba15t8bac4cd702ea7440-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-01-28 19:11   ` J. Bruce Fields [this message]
2009-01-28 22:05     ` Chuck Lever
2009-01-28 23:01       ` J. Bruce Fields
2009-01-29  3:05         ` Manish Katiyar
2009-01-29  3:53         ` Manish Katiyar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090128191104.GA6276@fieldses.org \
    --to=bfields@fieldses.org \
    --cc=akpm@linux-foundation.org \
    --cc=kandros@umich.edu \
    --cc=kmsmith@umich.edu \
    --cc=linux-nfs@vger.kernel.org \
    --cc=mkatiyar@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox